search

IntelPython / sdc

Numba extension for compiling Pandas data frames, Intel® Scalable Dataframe Compiler
https://intelpython.github.io/sdc-doc/
BSD 2-Clause "Simplified" License
645 stars 61 forks source link

Dependency for numpy 1.17 #977

Closed xaleryb closed 3 years ago

xaleryb commented 3 years ago

This PR is to follow Anaconda BKM to build using the oldest numpy with a stable API, which is 1.16. Intel's oldest numpy supporting python 3.7 is numpy 1.17, so we use that only at build time so ensure broadest compatibility with newer numpy versions.

Relates to https://github.com/tensorflow/tensorflow/issues/47691 (TensorFlow does not support numpy 1.20.x)

kozlov-alexey commented 3 years ago

Hi, @xaleryb, is this only for testing purposes? What is the rationale for this? I think we should not restrict numpy version for SDC at all, since by itself it doesn't need specific numpy.

xaleryb commented 3 years ago

hi @kozlov-alexey this is not for testing only we plan to merge and include to 2021.3 release. This is not a restriction because we do not set run dependency for numpy 1.17 (this is inly for building) and we expect sdc build (based on numpy 1.17) working with latest numpy which will be a part of 2021.3. This is for compatibility on AIKIt level

kozlov-alexey commented 3 years ago

this is not for testing only we plan to merge and include to 2021.3 release.

Then this has to merged to development branch first, as per our agreements.

But:

... we expect sdc build (based on numpy 1.17) working with latest numpy which will be a part of 2021.3. This is for compatibility on AIKIt level

this has impact not only on AIKit but anyone who will build SDC with conda. There should probably be other way to restrict numpy version that is used when building SDC for AIKit, shouldn't it?

kozlov-alexey commented 3 years ago

No description provided.

Please add description with motivation for this change and add the reference to related Github/Jira issues.

xaleryb commented 3 years ago

No description provided.

Please add description with motivation for this change and add the reference to related Github/Jira issues.

@tomashek could you please share this information if any. We need to merge this change ASAP because a lot of work we need to perform right after this to check our release is good to go.

tomashek commented 3 years ago

No description provided.

Please add description with motivation for this change and add the reference to related Github/Jira issues.

@kozlov-alexey , I do not think there is an Issue in this github to reference.