IntelPython / sdc

Numba extension for compiling Pandas data frames, Intel® Scalable Dataframe Compiler
https://intelpython.github.io/sdc-doc/
BSD 2-Clause "Simplified" License
646 stars 61 forks source link

Preparing for migration to numba=0.54 #981

Closed kozlov-alexey closed 3 years ago

kozlov-alexey commented 3 years ago

Motivation: keep up with the latest numba release.

pep8speaks commented 3 years ago

Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-08-17 22:22:24 UTC
kozlov-alexey commented 3 years ago

@AlexanderKalistratov, I've just updated to current master and pinned numba==0.54.0 in all files. Hopefully when it's released all checks should pass - they did locally when I checked with 0.54.0rc3, e.g.

FAILED sdc/tests/test_basic.py::TestBasic::test_assert - numba.core.errors.TypingError: Failed in nopython mode pipeline (step: nopython frontend) =================================================== 1 failed, 1257 passed, 477 skipped, 32 xfailed in 290.32s (0:04:50) ====================================================

(and test_assert really passes and fails only when l run it's via pytest -n).

xaleryb commented 3 years ago

@AlexanderKalistratov all required checks passed (wheels were deactivated some time ago). Any updates from Numba guys about readiness to publish numba 0.54.0 to conda channel?

AlexanderKalistratov commented 3 years ago

@xaleryb

Any updates from Numba guys about readiness to publish numba 0.54.0 to conda channel?

Scheduled for next week