search

IntelPython / sdc

Numba extension for compiling Pandas data frames, Intel® Scalable Dataframe Compiler
https://intelpython.github.io/sdc-doc/
BSD 2-Clause "Simplified" License
646 stars 61 forks source link

Merge master to gold #983

Closed AlexanderKalistratov closed 3 years ago

AlexanderKalistratov commented 3 years ago

@xaleryb

xaleryb commented 3 years ago

@AlexanderKalistratov if you will check current gold/2021 branch you can see restrictions for numpy version. We need to have the same after this PR merge.

AlexanderKalistratov commented 3 years ago

@xaleryb i don't see any changes to numpy version. Do you?

xaleryb commented 3 years ago

@xaleryb i don't see any changes to numpy version. Do you?

Restrictions for numpy version are present only for gold branch (were not merged to master previously). Based on this PR I see that recipe will be w/o restrictions on gold (after merge). That's not what we need. In this case we'll need one more PR to setup numpy restrictions again. But to be honest I expected to see numpy version changes highlighted in "Files changed " area of this PR.

Anyway, let's merge it and I'll add restrictions again if they will broken after this PR merge.

AlexanderKalistratov commented 3 years ago

@xaleryb limitations seems to be on it's place. https://github.com/IntelPython/sdc/blob/gold/2021/conda-recipe/meta.yaml#L29