search

IntelRealSense / meta-intel-realsense

Yocto layer for realsense-sdk and librealsense
https://realsense.intel.com/
Other
35 stars 26 forks source link

librealsense: make the lib available for catkin-based recipes #7

Closed rojkov closed 7 years ago

rojkov commented 8 years ago

Catkin-based packages like e.g. ROS's realsense-camera expect a special .cmake manifest file provided by the library.

This patch installs such file to /usr/share/librealsense/cmake.

Having librealsense-config.cmake installed by the recipe allows smoother integration of RealSense cameras with ROS (https://github.com/bmwcarit/meta-ros/pull/431).

mattcurfman commented 8 years ago

I'd also like to see this PR merged. Thanks for submitting it :)

bulwahn commented 7 years ago

I also would like to see this pull request merged, or at least have a public discussion why the maintainers do not merge it and what to do instead.

bulwahn commented 7 years ago

@rojkov Have you considered to submit the needed changes to the librealsense source repository, and make hence the patch to the recipe itself much smaller?

rojkov commented 7 years ago

I didn't want to pollute the librealsense repo with files needed neither for the used build system nor for IDE tooling. But sure I can submit the change. @avishaymahluf what do you think?

rojkov commented 7 years ago

Hm... I've just noticed that catkin enablers got accepted to librelasense. I guess the better approach would be to remake the recipe to inherit the catkin class instead of pkgconfig. Then all the needed files would be created and installed automatically, but at the cost of introducing the dependency on meta-ros unless catkin.bbclass gets into oe-core.

bulwahn commented 7 years ago

Okay, with this new development that we could simply build and install librealsense with catkin, I believe it might be better to create an own recipe for librealsense in meta-ros, and not rely on the meta-intel-realsense layer. Then both layers are independent from each other and self-contained, and the actual duplication in two layers is very small because the recipe for librealsense here is different than the one using catkin in meta-ros. @rojkov What do you think?

rojkov commented 7 years ago

@bulwahn Sorry for the delay, I've been reaching out to the devs.

We have a use case when a computer vision layer may want to include librealsense without depending on ROS and one more when ROS and CV are used together. So I'd like to avoid conflicts stemmed from the duplication. Let's wait a bit longer until the layer is updated to librealsense 1.11.2.

mattcurfman commented 7 years ago

Merged PR to ostro branch. Welcome new PR if required for master or morty branch also.