search

IntelRealSense / realsense_mipi_platform_driver

Intel® RealSense™ camera driver for GMSL* interface
GNU General Public License v2.0
15 stars 14 forks source link

Metadata related fixes (Rebased) #107

Closed jnzw closed 1 year ago

jnzw commented 2 years ago

This PR is basically #94 rebased on top of #105. Conflicts that occur in max9295.c and max9296.c have been resolved.

jnzw commented 2 years ago

@xzhangxa Could you please review?

xzhangxa commented 1 year ago

Hi @dmipx @ev-mp, this was not merged so I guess it's your decision not having metadata for IR (Y8, Y8I) stream. However there were a few changes are useful no matter enabling metadata of IR or not: the VI code change cleanup, reading config from device tree than hardcode, less copy size for metadata etc. It's still nice to have even we turn off metadata for IR.

So is this metadata of IR needed for future release, or not at all? We're doing a lot of device tree changes for the multi-D457 and some changes in this PR are still good to use, so we'd like to know this feature is still needed later? If no we will just move some parts of this.

dmipx commented 1 year ago

@xzhangxa there is many changes, we will need to do a thorough verification of everything. it will be better to split every orthogonal cchanges to different PR's so we can merge modifications step-by-step.

xzhangxa commented 1 year ago

@xzhangxa there is many changes, we will need to do a thorough verification of everything. it will be better to split every orthogonal cchanges to different PR's so we can merge modifications step-by-step.

Yes totally agree, we should split this patch, there was history about this patch then and it gradually grew this big. Just a few questions: the metadata for IR feature needed or not? In the following PRs do we need to update for both JetPack 4.6.1 and 5.0.2, or 4.6.1 will be frozen and only 5.0.2 to be updated?

xzhangxa commented 1 year ago

Close this since the IR MD feature is not needed and other useful code changes are already in JetPack 5 branch and following PRs.

Nir-Az commented 1 year ago

Actually IR metadata is a good feature, we just didn't had the bandwidth to verify and review it.. Is it still relevant with the new JP branch?

xzhangxa commented 1 year ago

The code was for JetPack 4.6.1 at the time so it's only applicable for 4.6.1.

For current JetPack-5.0.2 branch, a little refactor is needed; for #144 the serdes code is changed a lot but actually it makes it easier to enable IR MD with a few code changes (though we didn't try/test it).