Make d4xx unloadable - Githubissues

IntelRealSense / realsense_mipi_platform_driver

Intel® RealSense™ camera driver for GMSL* interface

GNU General Public License v2.0

15 stars 14 forks source link

Make d4xx unloadable #110

Closed jnzw closed 2 years ago

jnzw commented 2 years ago

Change sd->owner from THIS_MODULE to NULL so that we can unload the driver
Remove unnecessary try_module_get/module_put
Clean up metadata video nodes during remove
Make embedded.video dynamically allocated
Init embedded only if set in device tree
Disable metadata for IR in the DTS

jnzw commented 2 years ago

~~Only patch 62 is relevant, the other two patches are from #107.~~

jnzw commented 2 years ago

~~This PR depends on the metadata related changes in #107, namely adding metadata for IR, so we should consider merge that first.~~

jnzw commented 2 years ago

I've cleaned up this PR to include only necessary changes, and cherry-picked Xin's modification to enable dynamic creation of embedded metadata nodes based on DTS config.

@d1ntel @xzhangxa Could you please review? Thanks.

xzhangxa commented 2 years ago

It seems this branch no longer depends on on #107 and some code changes in that PR are moved here. Because that one won't be merged soon and this one will be merged earlier? Doing so you'll have to fix conflicts again for that PR later.

jnzw commented 2 years ago

@xzhangxa Yes, exactly. In the last meeting Evgeni said #107 can't be be merged soon, so we should merge this PR first and then fix that PR later. The code changes moved here are for creating metadata nodes based on dts configuration.