search

IntelRealSense / realsense_mipi_platform_driver

Intel® RealSense™ camera driver for GMSL* interface
GNU General Public License v2.0
15 stars 12 forks source link

DSO-18375 d4xx change parent I2C bus clock rate to fast, 400000 Hz #123

Closed dmipx closed 2 years ago

dmipx commented 2 years ago

Signed-off-by: Dmitry Perchanov dmitry.perchanov@intel.com

yorambenhaim commented 2 years ago
  • While DFU device opens, the bus clock rate will be saved and restored by DFU device close. Change clock rate to FAST mode, 400000Hz, while in DFU mode.
  • Addressing https://rsjira.intel.com/browse/DSO-18375 [D457] DFU I2C bus clock speed
  • fixed unload d4xx driver in dfu state

Signed-off-by: Dmitry Perchanov dmitry.perchanov@intel.com

Hi Dima. I'm not sure I understand the connection between your explanation to the implementation. You wrote 'While DFU device opens, the bus clock rate will be saved and...". Saved where? What about scenario that the user abort this session (i.e. Skipping the restore since the DFU device not closed) and come back what will be saved in the new session? 400KHZ or 100KHZ ? BTW. Can you ask Evgeni also to review this change?

dmipx commented 2 years ago

Clock rate saved in memory allocated structure served for DFU purpose. When user aborts DFU session, the device automatically closes thus restoring bus clock rate value to original one, whenever it was 100k or 400k (we define it today to 100k in devicetree). Camera will be in DFU-RECOVERY mode. Evgeny is mandatory for that PR, you where added FYI only