Metadata related fixes - Githubissues

xzhangxa commented 2 years ago

This PR contains the following:

Make metadata buffer smaller so copy on it could waste less CPU;
IR channel changed from 2 SerDes configs (Y8_Y8I, Y12I) to 3 configs (Y8, Y8I, Y12I), and Y8/Y8I configs enabled metadata datatype, the 2 datatypes per channel limitation is still respected while we could have metadata on IR Y8 and Y8I;
Enable metadata for IR, /dev/video5 will be IR metadata node;
Y12I doesn't have metadata, the metadata node /dev/video5 will output no data when the format is set to Y12I.
Metadata related code refactoring in MC/VI driver: cleanup, move related code into one place, get config from dt instead of hardcode.

Tested IR Y8 & Y8I metatdata with validation code https://github.com/jubransh/v4l_val_infra (modified myself, because currently IR metadata is disabled and the bpp for Y8I is wrong), and I see the metadata dumped.

xzhangxa commented 2 years ago

@qingwuzh please help review the changes in max9295/9296 and of course the rest of changes, thanks.

qingwuzh commented 2 years ago

Patch look good to me, but do you need to update script?

xzhangxa commented 2 years ago

Patch look good to me, but do you need to update script?

I guess not, current driver doesn't match latest script already (I remember the IR Y8I setting is different) :)

xzhangxa commented 2 years ago

This PR is rebased to latest master, thanks Shikun for fixing the Y12I streaming (reset regs set by Y8/Y8I configs for MD).

xzhangxa commented 2 years ago

Need rebase again on top of #105

xzhangxa commented 2 years ago

Need rebase again on top of #105

@jnzw is working on it and will provide a rebased PR later. Keep this open for now.

xzhangxa commented 2 years ago

Rebased #107 is ready, close this.

IntelRealSense / realsense_mipi_platform_driver

Metadata related fixes #94