ClipboardMessage class has been migrated from Kotlin to Java corresponding changes were made to the SyncService class. The code uses TypedJsonJacksonCodec instead of JsonJacksonCodec and direct getter methods were used for extracting userId and fromServer data from the message. The uncaught exceptions also now handled properly.
Types of changes
What types of changes does your code introduce to this project?
Put an x in the boxes that apply
[X] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
[X] I have read the CONTRIBUTING.md
[X] I have added tests that prove my fix is effective or that my feature works
[X] I have added necessary documentation (if appropriate)
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...
Proposed changes
ClipboardMessage class has been migrated from Kotlin to Java corresponding changes were made to the SyncService class. The code uses TypedJsonJacksonCodec instead of JsonJacksonCodec and direct getter methods were used for extracting userId and fromServer data from the message. The uncaught exceptions also now handled properly.
Types of changes
What types of changes does your code introduce to this project? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...