mindw0rm commented 4 years ago

NOTICE:

! PlotSquared for Minecraft Java Edition versions between 1.7 through to 1.12.2 are considered
! legacy, and will receive limited to no support. Please consider upgrading to 1.13+ for
! future support.  Plugins exist for 1.13+ which bring back behaviors found in 1.8.8
! All versions of PlotSquared for Sponge and Nukkit(X) will recieve limited to no support
! due to lack of developer interest and time. Additionally, NukkitX has not had feature
! updates since the Better Together, which prevents some PlotSquared features from ever
! functioning.  Contributions are always welcome however!

Feature requests & Suggestions are to be submitted at the PlotSquared Suggestions tracker

Code contributions are to be done through PRs, tagging the specific issue ticket(s) if applicable.

DISCORD INVITE LINK and please, for the love of the little sanity we have left, use the correct channels!

BUG REPORT TEMPLATE:

Required Information section:

ALL FIELDS IN THIS SECTION ARE REQUIRED, and must contain appropriate information

Server config info (Debug/file paste links):

https://athion.net/ISPaster/paste/view/cbe3b54357654ea7b931a6b1ed9a6a69

Server type:

select one

[X] Spigot / Paper (CraftBukkit should not be used, re-test with Spigot first!)
[] Sponge - NOTE: NOT ACTIVELY MAINTAINED
[] NukkitX - NOTE: NOT ACTIVELY MAINTAINED

Minecraft Version:

select one

[X] Minecraft 1.14.4 This is the ONLY actively maintained target for PlotSquared
[] Minecraft 1.13.2
[] Minecraft Java Edition other versions, please specify:
[] Minecraft Bedrock Edition specify version:

Server build info:

[17:32:42] [Server thread/INFO]: This server is running CraftBukkit version git-Spigot-56f8471-56118c6 (MC: 1.14.4) (Implementing API version 1.14.4-R0.1-SNAPSHOT)
[17:32:42] [Server thread/INFO]: Checking version, please wait...
[17:32:43] [Thread-9/INFO]: You are running the latest version

WorldEdit/FAWE versions:

[] FAWE version:
[X] WorldEdit version: 7.0.1;61bc012

Description of the problem:

The blocklist flags, i.e. use, break and place, stopped working with the newest version (4.390). This means that you cannot place/break/use blocks which are in those flags.

I tracked the issue down to this commit, where a Supplier<BlockState> is provided to EventUtil::checkPlayerBlockEvent, but the flags values are of type Set<BlockType>. Obviously the call to contains must fail.

How to replicate:

Add some block types to the flags (in my test I used /p flag add use lever, /p flag add place sand and /p flag add break sand) of some plot. Put those blocks on the plot (e.g. a lever and some sand).
Log in as a different user that is not added to the plot
try to use, break or place the blocks

Additional Information:

I already made a bugfix, you'll get a pull request soon.

Other plugins being used on the server:

none (except WorldEdit) - this is only a test server

Relevant console output, log lines, and/or screenshots:

n/a

Additional relevant comments/remarks:

I kept the preamble of the bug template, since it says that I should not remove it, but do you really want it? Imho everything above "Server config info" could be removed and the bug would be easier to read ...

AFFIRMATION OF COMPLETION:

[X] I included all information required in the sections above
[X] I made sure there are no duplicates of this report (Use Search)
[X] I made sure I am using an up-to-date version of PlotSquared
[X] I made sure the bug/error is not caused by any other plugin
[] I didn't read but checked everything above.