You can break blocks from the road while merging is in progress

RedstoneFuture commented 3 years ago

Server Implementation

Paper

Server Version

1.16.5

Describe the bug

Copy of https://issues.intellectualsites.com/issue/PS-169 by Diranus.

When you merge with "/p merge", the plot owner and trusted players can build/break blocks inside the road between. It seems like the plot area is merged internally before the roads are removed, resulting in break/build permissions in road not intended for building/breaking.

To Reproduce

Player A claims at least two adjacent plots
Player A trusts Player B on them.
Player B is standing on one of the plot and attempts to build/break blocks in the road between
Player A invokes the merge process by "/p merge"
For a short period of time, player B can break or build on the road, until the road disappears by the merging process.

The larger the merged plot is, the longer that period is.

Expected behaviour

Screenshots / Videos

grafik

Error log (if applicable)

The only console output is that player A typed "/p merge"

Plot Debugpaste

PlotSquared Version

5.13.6

Checklist

[X] I have included a Plot debugpaste.
[X] I am using the newest build from https://www.spigotmc.org/resources/77506/ and the issue still persists.

Anything else?

It allows some duping which harms multiplayer worlds. Especially if the plot borders, walls or the road itself is out of valueful materials (for example, a beacon border or a road out of some value stone). In our servers, strong fast break potion effects can be activated by the players which amplifies this issue (you can break multiple blocks out of the road in the short time between /p merge and completion of merging process).

RedstoneFuture commented 3 years ago

mmh ... maybe this isn't fixable at this time. You use a command (mostly for admins) to redefine your restriction region. It seems as normal that you have the permission in this fast process (< 2 s).

NotMyFault commented 3 years ago

I don't really see where this is an issue, because the road is gone after merging anyway.

RedstoneFuture commented 3 years ago

I don't really see where this is an issue, because the road is gone after merging anyway.

It's a little "problem" on survival plot-servers: you can farm valuable road materials in this short merge-process.

OneLiteFeather commented 1 year ago

We're on fixing it! Hang in there

OneLiteFeather commented 11 months ago

We actually have much trouble fixing it as this process is very complicated, help is welcome!

RedstoneFuture commented 11 months ago

And if you remove the games from the plot for a certain period of time until the merge process is complete?

PierreSchwang commented 11 months ago

And if you remove the games from the plot for a certain period of time until the merge process is complete?

Potentially replace the road first, wait until the EditSession is closed and the operation finished and then merge the plot itself (their data).

OneLiteFeather commented 11 months ago

And if you remove the games from the plot for a certain period of time until the merge process is complete?

Potentially replace the road first, wait until the EditSession is closed and the operation finished and then merge the plot itself (their data).

@TheMeinerLP and me will try that, thanks!

IntellectualSites / PlotSquared