IntellectualSites / PlotSquared

PlotSquared - Reinventing the plotworld
GNU General Public License v3.0
546 stars 748 forks source link

Make the "PvP" flag encompass reeling in players with a fishing rod #3090

Open TheosisOfficial opened 3 years ago

TheosisOfficial commented 3 years ago

What feature do you want to see added?

I, and I'm sure others upon realising, am not happy with the fact that players can use fishing rods to pull other players around and annoy them. Similar to how WorldGuard already does it, the "PvP" flag being set to "false" should cancel PlayerFishEvent when its State is CAUGHT_ENTITY, and said entity is a Player.

Are there any alternatives?

You can do this already by utilising WorldGuard's global region and setting its own PvP flag to "deny", but we shouldn't have to use WorldGuard flags in our plot worlds.

Anything else?

No response

NotMyFault commented 3 years ago

If the player is not added to the plot or has the permission plots.admin.interact.other/road they are not able to grab other players with the fishing rod.

TheosisOfficial commented 3 years ago

If the player is not added to the plot or has the permission plots.admin.interact.other/road they are not able to grab other players with the fishing rod.

I know, but I feel like players should not be able to affect each other at all, even if they are added to the plot etc.

NotMyFault commented 3 years ago

If a player annoys you that way simply remove them from the plot or tell them to stop. Adding Low Priority incase someone wants to add named behavior.

TheosisOfficial commented 3 years ago

If a player annoys you that way simply remove them from the plot or tell them to stop. Adding Low Priority incase someone wants to add named behavior.

I guess so. Cheers!