IntellectualSites / PlotSquared

PlotSquared - Reinventing the plotworld
GNU General Public License v3.0
539 stars 733 forks source link

Issue with PlotSquared API #4000

Closed MasonX3 closed 1 year ago

MasonX3 commented 1 year ago

Server Implementation

Paper

Server Version

1.19.3

Describe the bug

The developer of FlightControl is grabbing the plots using PlotSquared's API. The world exists, so it should be loaded under their BukkitWorld wrapper, but for some reason, it's acting like it doesn't exist (probably due to the way Multiverse loads its worlds)

Here's a snippet of their code: https://github.com/Spazzinq/FlightControl/blob/beta/FlightControl/src/main/java/org/spazzinq/flightcontrol/check/territory/trusted/PlotSquared6TrustedCheck.java

This causes /fly to be inaccessible, as well as disable the plugin.

To Reproduce

  1. Install Multiverse, PlotSquared, FAWE, and FlightControl
  2. Attempt to type /fly

Expected behaviour

The flight function should be fine, regardless of the world that it is in. The world "world" does exist, I tried this on a fresh server as well as my production server.

Screenshots / Videos

No response

Error log (if applicable)

https://paste.gg/p/anonymous/a419fba35cb24b51b62b5c501b439e4f

Plot Debugpaste

https://athion.net/ISPaster/paste/view/b22b549af9b04ff98c6673884fd32227

PlotSquared Version

PlotSquared 6.11.1-Premium

Checklist

Anything else?

I'm submitting this on behalf of the developer since I was the one that encountered the issue. I've tested removing plugins over and over but this issue only happens when PlotSquared is installed. There has to be something missing, I'm unsure if it's with you guys or FlightSquared's developer. I've spoken with him and he suggested that I take it to you guys to try and get some more information.

dordsor21 commented 1 year ago

Look at the error. CraftWorld{name=world} is clearly not a world. The code in FlightControl is very incorrect.