IntellectualSites / PlotSquared

PlotSquared - Reinventing the plotworld
GNU General Public License v3.0
552 stars 756 forks source link

Plot visit and home index is not the same #4136

Closed nicolube closed 1 year ago

nicolube commented 1 year ago

Server Implementation

Paper

Server Version

1.20.1

Describe the bug

If u do /p h 5 u land on /p v <username> 4 plot,

To Reproduce

Claim a few plots and use /p v <username> 3 and /p h 3, U will not be teleported to the same plot

Expected behaviour

/p v <username> 3 and /p h 3 Teleportet to the same plot

Screenshots / Videos

No response

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/2215d86df66f46d48a0d3c74ae4598bb

PlotSquared Version

PlotSquared-7.0.0-rc.3

Checklist

Anything else?

Also verfied on another server on rc-4

nicolube commented 1 year ago

Ok that is in of wierd, I have 2nd CB that is basicly the same and there it works flawlessly

OneLiteFeather commented 1 year ago

This is not how both command work, please read the documentation :) /p v means plot visit <player/alias> and /p h means your plot home and behind the number of your plot where you want to teleport. An alias can only be set once each server and always teleports to one spot for everyone.

dordsor21 commented 1 year ago

The index really should be the same, else you cannot say "go to my 3rd plot"

OneLiteFeather commented 1 year ago

grafik If so, why was this never a thing in Plotsquared 6.11.1 ?

The index really should be the same, else you cannot say "go to my 3rd plot"

Actually you can, but only with /plot home 3 but never with /plot visit 3 because it can only be a player (and fortunately setting an alias with 3 doesn't work as it must be alphanummerical) There must be something else broken that allows the command /p v 3 to work

dordsor21 commented 1 year ago

they were using visit correctly. The issue is your /plot home 3 is different to /plot visit 3

OneLiteFeather commented 1 year ago

https://intellectualsites.gitbook.io/plotsquared/commands#teleport You can't use /p v 3 because you always have to add a player. How would Plotsquared know where to go if you don't tell the owner of the plot. So if you need to go to a different players plot, use /p v and if you want to go to your plot /p h

dordsor21 commented 1 year ago

Looks like it was edited lol @nicolube please clarify

image
OneLiteFeather commented 1 year ago

I guess it could also be a merged plot @dordsor21 so all plots that are merged into one share the same home. But I am really not sure what is the issue behind this issue.

OneLiteFeather commented 1 year ago

@nicolube can you explain more in detail what you mean? It looks like it's not an issue but a missunderstanding.

nicolube commented 1 year ago

@nicolube can you explain more in detail what you mean? It looks like it's not an issue but a missunderstanding.

Well this is about that /p h 6 and /p v <username> 5 are the same plot for me. But I think it should be /p h 6 and /p v <username> 6

nicolube commented 1 year ago

Looks like it was edited lol @nicolube please clarify

It semms that Markdown removed <> tags, i added some code blocks to clarify that.

OneLiteFeather commented 1 year ago

Ah now I know what you mean, that is an issue for a long time. The plots with their index swap sometimes so they get out of the order they were claimed. You mean this @nicolube ?

nicolube commented 1 year ago

@OneLiteFeather Yes

nicolube commented 1 year ago

But they they are offset by one in this case between home and visit. When I'm on plot home 5 and ask someone to come by they land on and diffrent plot with plot visit.

I basikly need to search for my plot id with plot visit to share it

OneLiteFeather commented 1 year ago

Not sure if there is a duplicate because I've known this issue for quite a while (2 years) also in PS5 I guess, but changing or adding plot owners can reproduce this behaviour, so I guess this can be confirmed till we find a duplicate

RedstoneFuture commented 1 year ago

If I have 2 merged plots, the commands /p home <1 & 2> and /p v RedstoneFuture <1 & 2> are available for me. Of course, merged always counts as one plot. But with that, I can't replicate the bug report. HOME and VISIT numbers are always the same for the same plot.

/p home 4 corresponds /p v RedstoneFuture 4 for me and also for other players. No problems after a swap or setowner command. The order of the IDs for the plots is also correct.

Can you please test it on a clean test server with less plugins?

grafik

nicolube commented 1 year ago

Could it be this issue be caused from enabeling the Server Plot flag?

I can still teleport to a plot with /p h that has that flag enabled.

nicolube commented 1 year ago

I owned about 15 Plots, 14 Single Plots and one 3x3 Merge.

The 3x3 Merge was a server plot.

RedstoneFuture commented 1 year ago

Ah, okay, yes. That's intentional: With the server plot flag, you don't want other players to see that this is your plot. So any plot result shifts. But since it's your plot, you need the access to get it with the original plot ID.

Thus, the IDs are different for HOME and VISIT in this case. However, this is not a "bug", just simply technically justified.

nicolube commented 1 year ago

Ok, would it then not be better to remove it from /p h too? That the plot been treated as an plot that is not owned by a player.

As an example, Towny allows u to set a "Fake" Player as an town owner for thows that are owned by the server.

RedstoneFuture commented 1 year ago

Technically, in PlotSquared the "server-plot" is still your plot and is only hidden from the others by the plot flag!

It's not the same solution as Towny does.

RedstoneFuture commented 1 year ago

An unconventional solution: ban a player with a strange username "Server" or something and set this person as the owner of your current "server-plots".

People who are really called "Server" etc. don't play on servers anyway. And shouldn't.