Plot limit can be overwritten.

ch4ika commented 9 months ago

Server Implementation

Paper

Server Version

1.20.4

Describe the bug

The limitation can be circumvented by having the entity on a merged property where the road previously existed and walking around, so the plot cap is always recalculated and the transition to plot 1 to 2 where the road was ignored.

Fawe: 2.9.1-SNAPSHOT-659;c93ec87

To Reproduce

Setup these Flags in words.yml: flags: animal-cap: 1 mob-cap: 1 hostile-cap: 1 entity-cap: 1 vehicle-cap: 1 misc-cap: 1
To reproduce the whole thing. Do you need at least 2 plots that merged.
A villager should be spawned where the road used to be.
Hit this Villager so that it moves around a bit as the counts are then recalculated.
As soon as step 3 happens, another mob or misc can be spawned/set.
The whole thing can be done permanently without limits.

Reminder: There cannot be a mob on plot 1 and 2, it must be between 1 and 2 where the road was before.

Detailed instructions can be seen in the video above.

Expected behaviour

The limitation should be maintained and not be recalculated again and again as soon as a mob runs over the merged property. In general it should not be possible for the cap to be overwritten.

Screenshots / Videos

How to bypass cap: https://www.youtube.com/watch?v=KCqGM4RalOE&feature=youtu.be

ArmorStands are ignored by caps and can be placed infinitely. https://www.youtube.com/watch?v=0YuhzfdSx0I

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/756733ea33a144f7b23cf2e472a6b4dc

PlotSquared Version

7.3.4-Premium

Checklist

[X] I have included a Plot debugpaste.
[X] I am using the newest build from https://www.spigotmc.org/resources/77506/ and the issue still persists.

Anything else?

No response

Tamikaschu commented 9 months ago

Can confirm. Similar issue: https://github.com/IntellectualSites/PlotSquared/issues/3050 problem is not resolved for me though.

jvstinxz commented 9 months ago

I can confirm this, I have tested it as well https://athion.net/ISPaster/paste/view/8a1fd66a843040efb0e4037d254d18ad

DevinGebauer commented 9 months ago

i can confirm, same issue on my network, isnt resolved till now

assemblyenjoyer1 commented 9 months ago

Same issue, my guess is that the check for entities on the plot fails because the coordinates of the road thats gone due to the merge isnt being properly counted for

IntellectualSites / PlotSquared