IntellectualSites / PlotSquared

PlotSquared - Reinventing the plotworld
GNU General Public License v3.0
548 stars 754 forks source link

Remove unused SNOW field which triggers legacy mode #4472

Closed JLyne closed 3 months ago

JLyne commented 3 months ago

Description

There is a SNOW field in BlockEventListener which seems to be a remnant of handling the introduction of powdered snow in 1.17. I can find no uses of this field, and snow-related code in this file uses Tag.SNOW directly.

The material iteration for setting this field is also unnecessarily triggering the legacy material system, so it is best removed.

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).