Added FAWE and FAVS project logo to gitbook homepage

IntellectualSites / documentation

A collection of documentation sources for our plugins hosted on gitbook

https://intellectualsites.gitbook.io/

MIT License

4 stars 8 forks source link

Added FAWE and FAVS project logo to gitbook homepage #41

Closed specbeck closed 10 months ago

specbeck commented 11 months ago

Overview

Fixes #39

Description

Adds respective project logos to the homepages rendered by gitbook as a tile as per the structure used in https://intellectualsites.gitbook.io/plotsquared/

Submitter Checklist

[x] Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
[x] Ensure that the pull request title represents the desired changelog entry.
[x] New public fields and methods are annotated with @since TODO.
[x] I read and followed the contribution guidelines.

NotMyFault commented 11 months ago

Can't we use the SVG from the asset repo with scaling?

specbeck commented 11 months ago

Sure, I'll do that

NotMyFault commented 11 months ago

Sure, I'll do that

I meant as raw URL, instead of duplicating the content by adding images.

specbeck commented 11 months ago

I meant as raw URL, instead of duplicating the content by adding images.

Oh, apologies. Is the same needed to be done for the FAVS logo too?

NotMyFault commented 11 months ago

On 23. Oct 2023, at 17:51, Saransh Sood @.***> wrote:

I meant as raw URL, instead of duplicating the content by adding images.

Oh, apologies. Is the same needed to be done for FAVS logo too?

— Reply to this email directly, view it on GitHub https://github.com/IntellectualSites/documentation/pull/41#issuecomment-1775505451, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGDOVM5ALAKL3KIYKB43OTYA2HBFAVCNFSM6AAAAAA6L5ELNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZVGUYDKNBVGE. You are receiving this because you commented.

NotMyFault commented 10 months ago

You forgot to include the FAWE logo.

specbeck commented 10 months ago

Wasn't that supposed to be added as a raw URL?

NotMyFault commented 10 months ago

Wasn't that supposed to be added as a raw URL?

Surely, but the icon should come from the asset repo, not as blog from a commit.

specbeck commented 10 months ago

I tired adding the asset link directly, as in b54ee2a970ea06bf15668da054b57675d81d05b5, but it didn't render the logo.

I'd very much like to know what went wrong :)

NotMyFault commented 10 months ago

I tired adding the asset link directly, as in b54ee2a, but it didn't render the logo.

I'd very much like to know what went wrong :)

You'll need to use the direct image URL, such as https://raw.githubusercontent.com/IntellectualSites/Assets/main/plugins/FastAsyncWorldEdit/FastAsyncWorldEdit.svg

specbeck commented 10 months ago

Thanks, all set to go