search

IntellectualSites / documentation

A collection of documentation sources for our plugins hosted on gitbook
https://intellectualsites.gitbook.io/
MIT License
4 stars 8 forks source link

chore: update ps logo colors and use svg #44

Closed PierreSchwang closed 7 months ago

PierreSchwang commented 10 months ago

Overview

Make the logo more ✨ crisp ✨ by using the svg variant (and also don't use the weird redish-beigeish color). Not referenced by url to assets repo due to not being minified (gotta save those kilobytes)

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).
NotMyFault commented 10 months ago

Wouldn't it make more sense to use the assets from the asset repo and make modifications there?

PierreSchwang commented 10 months ago

Wouldn't it make more sense to use the assets from the asset repo and make modifications there?

Possible yes, tho that makes editing the svg kinda nasty. We could add a GitHub action that does the minimizing stuff automatically and puts it into a subfolder / prefixed file tho.

NotMyFault commented 10 months ago

Wouldn't it make more sense to use the assets from the asset repo and make modifications there?

Possible yes, tho that makes editing the svg kinda nasty. We could add a GitHub action that does the minimizing stuff automatically and puts it into a subfolder / prefixed file tho.

What would you need a GH action for, when you can submit a PR with this change to the asset repository and then working with a hardlink from the asset repo in this repo 🤔