search

IntellectualSites / fastasyncvoxelsniper

Voxel Sniper fork for modern Minecraft versions utilizing the improvements of FastAsyncWorldEdit
GNU General Public License v3.0
72 stars 24 forks source link

UnknownSniperPlayerException: Sniper player not found #326

Closed SecretlyJealous closed 8 months ago

SecretlyJealous commented 9 months ago

Server Implementation

Paper

Server Version

1.20.2

Describe the bug

Every time a player joins an error is printed in console: 

[11:44:58 INFO]: UUID of player xPhantoMTVx is 352e18f2-85c5-4c65-b917-fdf85d761338
[11:44:58 ERROR]: Caught previously unhandled exception :
[11:44:58 ERROR]: Paper Async Command Builder Thread Pool - 92
com.thevoxelbox.voxelsniper.sniper.UnknownSniperPlayerException: Sniper player not found
        at com.thevoxelbox.voxelsniper.sniper.Sniper.getPlayer(Sniper.java:83) ~[fastasyncvoxelsniper-3.0.0.jar:?]
        at com.thevoxelbox.voxelsniper.sniper.Sniper.getCommandSender(Sniper.java:90) ~[fastasyncvoxelsniper-3.0.0.jar:?]
        at com.thevoxelbox.voxelsniper.cloud.bukkit.BukkitCommandManager.hasPermission(BukkitCommandManager.java:282) ~[fastasyncvoxelsniper-3.0.0.jar:?]
        at com.thevoxelbox.voxelsniper.cloud.CommandManager.hasPermission(CommandManager.java:427) ~[fastasyncvoxelsniper-3.0.0.jar:?]
        at com.thevoxelbox.voxelsniper.cloud.bukkit.BukkitCommand.testPermissionSilent(BukkitCommand.java:216) ~[fastasyncvoxelsniper-3.0.0.jar:?]
        at org.bukkit.craftbukkit.v1_20_R2.command.BukkitCommandWrapper.test(BukkitCommandWrapper.java:56) ~[paper-1.20.2.jar:git-Paper-291]
        at org.bukkit.craftbukkit.v1_20_R2.command.BukkitCommandWrapper.test(BukkitCommandWrapper.java:23) ~[paper-1.20.2.jar:git-Paper-291]
        at com.mojang.brigadier.tree.CommandNode.canUse(CommandNode.java:79) ~[paper-1.20.2.jar:git-Paper-291]
        at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:491) ~[?:?]
        at net.minecraft.commands.Commands.sendAsync(Commands.java:449) ~[?:?]
        at net.minecraft.commands.Commands.lambda$sendCommands$5(Commands.java:422) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
        at java.lang.Thread.run(Thread.java:1623) ~[?:?]
[11:44:58 INFO]: xPhantoMTVx[/*] logged in with entity id 12354 at ([plotworld]93.34008738356125, 130.78351900370598, -407.17732072095424)

To Reproduce

  1. Update to FAVS 3.0.0
  2. Join the server

Expected behaviour

No error in console

Screenshots / Videos

No response

Error log (if applicable)

No response

Favs Debugpaste

https://athion.net/ISPaster/paste/view/3606f05150794ed0a3f3c7b74f0ec02f

Favs Version

FastAsyncVoxelSniper version 3.0.0

Checklist

Anything else?

No response

IAISI commented 9 months ago

I'm seeing the same error on latest Paper it started happening with 3.0.0 update

envizar commented 9 months ago

Same error Pls fix this

Aurelien30000 commented 9 months ago

Hello!

Thanks for your report, we are fully aware of this issue.

I'm currently unable to reproduce it on a basic similar setup. Could you please provide more details if you are affected? If possible, try to provide specific steps to reproduce the issue from scratch.

In any case, this error should not cause any trouble to FAVS, you can safely ignore it.

IAISI commented 9 months ago

Sure thing...


> ver
[15:29:28 INFO]: Checking version, please wait...
[15:29:28 INFO]: This server is running Paper version git-Paper-298 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: e1cd9e5)
You are running the latest version
Previous version: git-Paper-297 (MC: 1.20.2)
> ver FastAsyncWorldEdit
[15:29:32 INFO]: FastAsyncWorldEdit version 2.8.3-SNAPSHOT-609;c0a2eef
[15:29:32 INFO]: Blazingly fast world manipulation for builders, large networks and developers.
[15:29:32 INFO]: Website: https://www.spigotmc.org/resources/13932/
[15:29:32 INFO]: Authors: Empire92, MattBDev, IronApollo, dordsor21 and NotMyFault
> ver FastAsyncVoxelSniper
[15:29:34 INFO]: FastAsyncVoxelSniper version 3.0.0
[15:29:34 INFO]: World editing from ingame using 3D brushes
[15:29:34 INFO]: Website: https://dev.bukkit.org/projects/favs
[15:29:34 INFO]: Authors: Empire92, przerwap, MikeMatrix, Gavjenks, giltwist, psanker, Deamon5550, DivineRage, pitcer, jaqobb, NotMyFault and Aurelien30000
[15:29:38 INFO]: UUID of player MyUsername is MyUUID
[15:29:38 ERROR]: Caught previously unhandled exception :
[15:29:38 ERROR]: Paper Async Command Builder Thread Pool - 10
com.thevoxelbox.voxelsniper.sniper.UnknownSniperPlayerException: Sniper player not found
        at com.thevoxelbox.voxelsniper.sniper.Sniper.getPlayer(Sniper.java:83) ~[FastAsyncVoxelSniper.jar:?]
        at com.thevoxelbox.voxelsniper.sniper.Sniper.getCommandSender(Sniper.java:90) ~[FastAsyncVoxelSniper.jar:?]
        at com.thevoxelbox.voxelsniper.cloud.bukkit.BukkitCommandManager.hasPermission(BukkitCommandManager.java:282) ~[FastAsyncVoxelSniper.jar:?]
        at com.thevoxelbox.voxelsniper.cloud.CommandManager.hasPermission(CommandManager.java:427) ~[FastAsyncVoxelSniper.jar:?]
        at com.thevoxelbox.voxelsniper.cloud.bukkit.BukkitCommand.testPermissionSilent(BukkitCommand.java:216) ~[FastAsyncVoxelSniper.jar:?]
        at org.bukkit.craftbukkit.v1_20_R2.command.BukkitCommandWrapper.test(BukkitCommandWrapper.java:56) ~[paper-1.20.2.jar:git-Paper-298]
        at org.bukkit.craftbukkit.v1_20_R2.command.BukkitCommandWrapper.test(BukkitCommandWrapper.java:23) ~[paper-1.20.2.jar:git-Paper-298]
        at com.mojang.brigadier.tree.CommandNode.canUse(CommandNode.java:79) ~[paper-1.20.2.jar:git-Paper-298]
        at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:491) ~[?:?]
        at net.minecraft.commands.Commands.sendAsync(Commands.java:449) ~[?:?]
        at net.minecraft.commands.Commands.lambda$sendCommands$5(Commands.java:422) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
        at java.lang.Thread.run(Thread.java:840) ~[?:?]

It would happen on join, even on rejoin... basically every time a player would join the server

Aurelien30000 commented 9 months ago

Apologies for that but I'm unable to reproduce the issue as easily as you described it for now. There should be an impacting setting / plugin / link but I'm still not able to determine the cause.

OneLiteFeather commented 9 months ago

Apologies for that but I'm unable to reproduce the issue as easily as you described it for now. There should be an impacting setting / plugin / link but I'm still not able to determine the cause.

It could be a paper issue, they had some updates 6 days ago or it is even a third party plugin. I can try too for sure :)

IAISI commented 9 months ago

We run 2 creative servers, test server and actual server and I've just realized this doesn't show up on test server, still trying to figure out what's the difference...

IAISI commented 9 months ago

After a lot of digging around I found out world files are the issue, we've kept the same world from 1.8, gradually updated to latest 1.20 but as soon as I swap world with new one, running the same configuration, same plugins, everything else same... the issue disappears... running forceUpgrade right now, will check if that fixes the issue.

IAISI commented 9 months ago

I can't really explain it and it's probably not FAVS issue but renaming data folder in world folder fixed the issue.

It contained idcounts.dat, 35k of map files and raids.dat, random_sequences.dat, scoreboard.dat, Stronghold.dat, villages.dat

It's not an issue for us since we're running creative server and that data is mostly useless... but strange nevertheless

IAISI commented 9 months ago

Furthermore tab auto complete was also broken for all cmds, and this also fixed that issue...

and just now I've rolled back data folder and tested just by removing scoreboard.dat from data folder from main world folder and that fixed the issue.

And rolling back scoreboard.dat would cause the issue to arise again.

TLDR: If you're having the same issue go to your main world folder that has player data, into data/ directory and remove scoreboard.dat

IAISI commented 9 months ago

Screenshot 2023-11-28 at 02-21-27 NBT Editor

For future reference but as I said that's probably not FAVS bug.

Aurelien30000 commented 9 months ago

This is really interesting! Knowning that the stacktrace references a place where the player instances are retrieved from their UUIDs, there might be an issue with server/spigot/paper (absolutely unsure) & former data files. This makes sense with your explanations, even if the scoreboard.dat has just nothing to with our plugin infrastructure, neither with FAVS nor cloud.

ph59x commented 9 months ago

Reproduced on Paper-1.18.2-388, even using new generated world.

But when I run the server locally and connect using localhost, it acts normally.

Log for remote server

[17:30:48] [ServerMain/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[17:30:48] [Worker-Main-1/INFO]: Loaded 7 recipes
[17:30:49] [Server thread/INFO]: Starting minecraft server version 1.18.2
[17:30:49] [Server thread/INFO]: Loading properties
[17:30:49] [Server thread/INFO]: This server is running Paper version git-Paper-388 (MC: 1.18.2) (Implementing API version 1.18.2-R0.1-SNAPSHOT) (Git: fc9ee65 on ver/1.18.2)
[17:30:49] [Server thread/INFO]: Server Ping Player Sample Count: 12
[17:30:49] [Server thread/INFO]: Using 4 threads for Netty based IO
[17:30:49] [Server thread/INFO]: Default game type: SURVIVAL
[17:30:49] [Server thread/INFO]: Generating keypair
[17:30:49] [Server thread/INFO]: Starting Minecraft server on *:21112
[17:30:49] [Server thread/INFO]: Using epoll channel type
[17:30:49] [Server thread/INFO]: Paper: Using libdeflate (Linux x86_64) compression from Velocity.
[17:30:49] [Server thread/INFO]: Paper: Using OpenSSL 1.1.x (Linux x86_64) cipher from Velocity.
[17:30:49] [Server thread/INFO]: [FastAsyncWorldEdit] Loading FastAsyncWorldEdit v2.8.2-SNAPSHOT
[17:30:49] [Server thread/INFO]: Got request to register class com.sk89q.worldedit.bukkit.BukkitServerInterface with WorldEdit [com.sk89q.worldedit.extension.platform.PlatformManager@64454eb1]
[17:30:49] [Server thread/INFO]: [goPaint] Loading goPaint v3.1.0-75
[17:30:49] [Server thread/INFO]: [FastAsyncVoxelSniper] Loading FastAsyncVoxelSniper v3.0.0
[17:30:49] [Server thread/INFO]: [goBrush] Loading goBrush v3.8.0-67
[17:30:49] [Server thread/INFO]: [Arceon] Loading Arceon v0.4.3_1.16+
[17:30:49] [Server thread/INFO]: Server permissions file permissions.yml is empty, ignoring it
[17:30:49] [Server thread/INFO]: [FastAsyncWorldEdit] Enabling FastAsyncWorldEdit v2.8.2-SNAPSHOT
[17:30:49] [Server thread/INFO]: [com.fastasyncworldedit.core.Fawe] LZ4 Compression Binding loaded successfully
[17:30:49] [Server thread/INFO]: [com.fastasyncworldedit.core.Fawe] ZSTD Compression Binding loaded successfully
[17:30:49] [Server thread/INFO]: Registering commands with com.sk89q.worldedit.bukkit.BukkitServerInterface
[17:30:49] [Server thread/INFO]: WEPIF: Using the Bukkit Permissions API.
[17:30:49] [Server thread/INFO]: Using com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_18_R2.PaperweightFaweAdapter as the Bukkit adapter
[17:30:50] [Server thread/INFO]: Preparing level "world"
[17:30:51] [ForkJoinPool.commonPool-worker-1/WARN]: [com.fastasyncworldedit.core.util.UpdateNotification] An update for FastAsyncWorldEdit is available. You are 613 build(s) out of date.
You are running build 0, the latest version is build 613.
Update at https://www.spigotmc.org/resources/13932/
[17:30:52] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[17:30:52] [Server thread/INFO]: Time elapsed: 113 ms
[17:30:52] [Server thread/INFO]: Preparing start region for dimension minecraft:the_nether
[17:30:52] [Server thread/INFO]: Time elapsed: 54 ms
[17:30:52] [Server thread/INFO]: Preparing start region for dimension minecraft:the_end
[17:30:52] [Server thread/INFO]: Time elapsed: 39 ms
[17:30:52] [Server thread/INFO]: [goPaint] Enabling goPaint v3.1.0-75
[17:30:52] [Server thread/INFO]: [FastAsyncVoxelSniper] Enabling FastAsyncVoxelSniper v3.0.0
[17:30:53] [Server thread/INFO]: [goBrush] Enabling goBrush v3.8.0-67
[17:30:53] [Server thread/INFO]: [Arceon] Enabling Arceon v0.4.3_1.16+
[17:30:57] [Server thread/INFO]: [Arceon] Arceon loading...
[17:30:57] [Server thread/INFO]: [Arceon] Loading config...
[17:30:57] [Server thread/INFO]: [Arceon] Loaded 11 fonts!
[17:30:57] [Server thread/INFO]: Running delayed init tasks
[17:30:57] [Server thread/INFO]: Done (8.551s)! For help, type "help"
[17:30:57] [Server thread/INFO]: Timings Reset
[17:30:58] [Craft Scheduler Thread - 2 - FastAsyncVoxelSniper/INFO]: [com.thevoxelbox.voxelsniper.VoxelSniperPlugin] Your version is up to date.
[17:31:08] [User Authenticator #1/INFO]: UUID of player player is playerUUID
[17:31:08] [Paper Async Task Handler Thread - 0/ERROR]: Caught previously unhandled exception :
[17:31:08] [Paper Async Task Handler Thread - 0/ERROR]: Paper Async Task Handler Thread - 0
com.thevoxelbox.voxelsniper.sniper.UnknownSniperPlayerException: Sniper player not found
    at com.thevoxelbox.voxelsniper.sniper.Sniper.getPlayer(Sniper.java:83) ~[fastasyncvoxelsniper-3.0.0.jar:?]
    at com.thevoxelbox.voxelsniper.sniper.Sniper.getCommandSender(Sniper.java:90) ~[fastasyncvoxelsniper-3.0.0.jar:?]
    at com.thevoxelbox.voxelsniper.cloud.bukkit.BukkitCommandManager.hasPermission(BukkitCommandManager.java:282) ~[fastasyncvoxelsniper-3.0.0.jar:?]
    at com.thevoxelbox.voxelsniper.cloud.CommandManager.hasPermission(CommandManager.java:427) ~[fastasyncvoxelsniper-3.0.0.jar:?]
    at com.thevoxelbox.voxelsniper.cloud.bukkit.BukkitCommand.testPermissionSilent(BukkitCommand.java:216) ~[fastasyncvoxelsniper-3.0.0.jar:?]
    at org.bukkit.craftbukkit.v1_18_R2.command.BukkitCommandWrapper.test(BukkitCommandWrapper.java:48) ~[paper-1.18.2.jar:git-Paper-388]
    at org.bukkit.craftbukkit.v1_18_R2.command.BukkitCommandWrapper.test(BukkitCommandWrapper.java:20) ~[paper-1.18.2.jar:git-Paper-388]
    at com.mojang.brigadier.tree.CommandNode.canUse(CommandNode.java:78) ~[paper-1.18.2.jar:git-Paper-388]
    at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:417) ~[?:?]
    at net.minecraft.commands.Commands.sendAsync(Commands.java:380) ~[?:?]
    at net.minecraft.commands.Commands.sendCommands(Commands.java:364) ~[?:?]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
    at java.lang.Thread.run(Thread.java:833) ~[?:?]
[17:31:08] [Server thread/INFO]: player joined the game
[17:31:08] [Server thread/INFO]: player[/remoteaddress] logged in with entity id 259 at ([world]26.5, 64.0, -2.5)
[17:31:18] [Server thread/INFO]: player issued server command: /gamemode creative
[17:31:18] [Server thread/INFO]: [player: Set own game mode to Creative Mode]
[17:32:39] [Server thread/INFO]: player lost connection: Disconnected
[17:32:39] [Server thread/INFO]: player left the game

Log for local server

[19:06:49] [ServerMain/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[19:06:49] [ServerMain/INFO]: Found new data pack file/bukkit, loading it automatically
[19:06:50] [Worker-Main-4/INFO]: Loaded 7 recipes
[19:06:52] [Server thread/INFO]: Starting minecraft server version 1.18.2
[19:06:52] [Server thread/INFO]: Loading properties
[19:06:52] [Server thread/INFO]: This server is running Paper version git-Paper-388 (MC: 1.18.2) (Implementing API version 1.18.2-R0.1-SNAPSHOT) (Git: fc9ee65 on ver/1.18.2)
[19:06:52] [Server thread/INFO]: Server Ping Player Sample Count: 12
[19:06:52] [Server thread/INFO]: Using 4 threads for Netty based IO
[19:06:52] [Server thread/INFO]: Default game type: SURVIVAL
[19:06:52] [Server thread/INFO]: Generating keypair
[19:06:52] [Server thread/INFO]: Starting Minecraft server on *:21121
[19:06:52] [Server thread/INFO]: Using default channel type
[19:06:52] [Server thread/INFO]: Paper: Using Java 11 compression from Velocity.
[19:06:52] [Server thread/INFO]: Paper: Using Java cipher from Velocity.
[19:06:53] [Server thread/INFO]: [FastAsyncWorldEdit] Loading FastAsyncWorldEdit v2.8.2-SNAPSHOT
[19:06:54] [Server thread/INFO]: Got request to register class com.sk89q.worldedit.bukkit.BukkitServerInterface with WorldEdit [com.sk89q.worldedit.extension.platform.PlatformManager@4f3b8d72]
[19:06:54] [Server thread/INFO]: [goPaint] Loading goPaint v3.1.0-75
[19:06:54] [Server thread/INFO]: [FastAsyncVoxelSniper] Loading FastAsyncVoxelSniper v3.0.0
[19:06:54] [Server thread/INFO]: [goBrush] Loading goBrush v3.8.0-67
[19:06:54] [Server thread/INFO]: [Arceon] Loading Arceon v0.4.3_1.16+
[19:06:54] [Server thread/INFO]: Server permissions file permissions.yml is empty, ignoring it
[19:06:54] [Server thread/INFO]: [FastAsyncWorldEdit] Enabling FastAsyncWorldEdit v2.8.2-SNAPSHOT
[19:06:54] [Server thread/INFO]: [com.fastasyncworldedit.core.Fawe] LZ4 Compression Binding loaded successfully
[19:06:54] [Server thread/INFO]: [com.fastasyncworldedit.core.Fawe] ZSTD Compression Binding loaded successfully
[19:06:54] [Server thread/INFO]: Registering commands with com.sk89q.worldedit.bukkit.BukkitServerInterface
[19:06:54] [Server thread/INFO]: WEPIF: Using the Bukkit Permissions API.
[19:06:54] [Server thread/INFO]: Using com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_18_R2.PaperweightFaweAdapter as the Bukkit adapter
[19:06:55] [Server thread/INFO]: Preparing level "world"
[19:07:02] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[19:07:03] [Server thread/INFO]: Time elapsed: 998 ms
[19:07:03] [Server thread/INFO]: Preparing start region for dimension minecraft:the_end
[19:07:04] [Worker-Main-3/INFO]: Preparing spawn area: 0%
[19:07:04] [Worker-Main-3/INFO]: Preparing spawn area: 0%
[19:07:04] [Worker-Main-3/INFO]: Preparing spawn area: 0%
[19:07:04] [Worker-Main-3/INFO]: Preparing spawn area: 0%
[19:07:05] [Server thread/INFO]: Time elapsed: 1982 ms
[19:07:05] [Server thread/INFO]: Preparing start region for dimension minecraft:the_nether
[19:07:06] [Worker-Main-4/INFO]: Preparing spawn area: 0%
[19:07:06] [Worker-Main-4/INFO]: Preparing spawn area: 0%
[19:07:06] [Worker-Main-1/INFO]: Preparing spawn area: 0%
[19:07:06] [Worker-Main-1/INFO]: Preparing spawn area: 0%
[19:07:07] [Server thread/INFO]: Time elapsed: 1965 ms
[19:07:07] [Server thread/INFO]: [goPaint] Enabling goPaint v3.1.0-75
[19:07:07] [Server thread/INFO]: [FastAsyncVoxelSniper] Enabling FastAsyncVoxelSniper v3.0.0
[19:07:08] [Server thread/INFO]: [goBrush] Enabling goBrush v3.8.0-67
[19:07:08] [Server thread/INFO]: [Arceon] Enabling Arceon v0.4.3_1.16+
[19:07:10] [Server thread/INFO]: [Arceon] Arceon loading...
[19:07:10] [Server thread/INFO]: [Arceon] Loading config...
[19:07:10] [Server thread/INFO]: [Arceon] Loaded 11 fonts!
[19:07:11] [Server thread/INFO]: Running delayed init tasks
[19:07:11] [Server thread/INFO]: Done (18.586s)! For help, type "help"
[19:07:11] [Server thread/INFO]: Timings Reset
[19:07:13] [Craft Scheduler Thread - 2 - FastAsyncVoxelSniper/INFO]: [com.thevoxelbox.voxelsniper.VoxelSniperPlugin] Your version is up to date.
[19:07:41] [User Authenticator #1/INFO]: UUID of player player is playerUUID
[19:07:41] [Server thread/INFO]: player joined the game
[19:07:41] [Server thread/INFO]: player[/[0:0:0:0:0:0:0:1]:14026] logged in with entity id 321 at ([world]9.5, 67.0, -8.5)
[19:07:48] [Server thread/INFO]: player lost connection: Disconnected
[19:07:48] [Server thread/INFO]: player left the game

Tested on these environment

For local server

OS: Windows 10 21H2 Output of java -version:

openjdk version "17.0.8" 2023-07-18
OpenJDK Runtime Environment (Alibaba Dragonwell Standard Edition)-17.0.7.0.7+7-GA (build 17.0.8+7)
OpenJDK 64-Bit Server VM (Alibaba Dragonwell Standard Edition)-17.0.7.0.7+7-GA (build 17.0.8+7, mixed mode, sharing)

For remote server

OS: Windows Server 2019 Output of java -version:

java version "17.0.9" 2023-10-17 LTS
Java(TM) SE Runtime Environment (build 17.0.9+11-LTS-201)
Java HotSpot(TM) 64-Bit Server VM (build 17.0.9+11-LTS-201, mixed mode, sharing)

OS: Debian 11 Output of java -version:

openjdk version "17.0.8" 2023-07-18
OpenJDK Runtime Environment (Alibaba Dragonwell Standard Edition)-17.0.7.0.7+7-GA (build 17.0.8+7)
OpenJDK 64-Bit Server VM (Alibaba Dragonwell Standard Edition)-17.0.7.0.7+7-GA (build 17.0.8+7, mixed mode)
TheMeinerLP commented 9 months ago

The test results looks litte bit odd. Because you say you have two versions of java but only one is using. Can you please provide log + another debug paste. Also its possible the Alibaba Java Version breaks some runtime behaviors.

IAISI commented 9 months ago

I was using the same version of Java on both instances, I suspect this is caused by outdated worlds, players using hacks in GM 1 or plugin putting something bad in scoreboard.dat.

@ph59x you can replicate this with brand new world?

TheMeinerLP commented 9 months ago

I suspect this is caused by outdated worlds

This error can only be happend, if the player not fully registered inside of bukkit/paper.

About your hacks problem: If you have too many plugins that manipulate essential code(Native Minecraft Source aka NMS) of bukkit/paper you will run into problems.

A fresh setup of only the world(s), FAVS and FAWE is enough. If you can replicate the issue it would be fine then provide us the server data. When you can't replicate the issue with two plugins, then you need to sort out the plugins selectively of your current setup(see above).

IAISI commented 9 months ago

I can replicate with any kind of setup, the only thing that was different for me was scoreboard.dat

I can replicate by setting up new server, new world, only FAWE and FAVS and only transferring old scoreboard.dat there to replicate

TheMeinerLP commented 9 months ago

I can replicate with any kind of setup, the only thing that was different for me was scoreboard.dat

Why with scoreboard.dat ? Please give me the prove with any kind of setup. When the scoreboard is the problem, then you need to report that to paper instead of here!

IAISI commented 9 months ago

That's what I'm saying, I think this is paper bug and ppl having this issue have bad scoreboard.dat file

Edit: My bad I just saw @ph59x was using newly generated world.

ph59x commented 9 months ago

If needed, I could test again later using Oracle's java runtime. I will set up new paper servers, use FAWE, FAVS and generate new world.

Should I use the same seed for world generation or just leave it blank?

By the way currently my solution is downgrade FAVS to 2.9.4. It runs normally as it should be.

ph59x commented 9 months ago

Replicate again.

Description

Every time a player joins the error is printed in console, and command completion will fail. Except these cases:

Test Environment

File structure

Below is what's in the server folder and /plugins (2 images) image image

Java used

>java -version
java version "17.0.9" 2023-10-17 LTS
Java(TM) SE Runtime Environment (build 17.0.9+11-LTS-201)
Java HotSpot(TM) 64-Bit Server VM (build 17.0.9+11-LTS-201, mixed mode, sharing)

Plugins used

FAWS 2.8.2 FAVS 3.0.0

Test steps

  1. Start server
  2. Player join
  3. Run /op <player>
  4. Player exit
  5. Player join
  6. Try using command completion
  7. Stop server
  8. Start server
  9. Player join and validate command completion
  10. Player exit
  11. Player join and validate command completion

How to reproduce

  1. Setup a new paper server
  2. Install FAVS 3.0.0
  3. Start and join the server
  4. Exit and join again

Debugpaste

https://athion.net/ISPaster/paste/view/901d764b110f44b8afd4d58709b2d24c https://athion.net/ISPaster/paste/view/00497713259b49338b041f423ed0d85c

Why it has 2 debugpaste

The first one was generated from /fawe debugpaste. While editing this comment, I found wrong command was used. So I restarted server, enter it and run /favs debugpaste.

Logs

1.log 2.log

Mostoneman commented 8 months ago

Hey, I have the same issue, however it seems to even prevent any player to connect to the server. The server is running on spigot with some plugins:

When starting the server with all those settings on either 1.20.2 or 1.20.4, players can't connect because of "Invalid Player Data". Restarting the server without FAVS allows players to connect. I have tried to remove "scoreboard.dat" from the main world and starting the server with FAVS and it didn't work.

The issue started appearing when I updated from spigot 1.20.1 to 1.20.2 and I updated plugins including FAVS, and persisted on lastest spigot (1.20.4).

Here is the console error message whena player tries connecting:

[Server thread/ERROR]: Couldn't place player in world com.thevoxelbox.voxelsniper.sniper.UnknownSniperPlayerException: Sniper player not found at com.thevoxelbox.voxelsniper.sniper.Sniper.getPlayer(Sniper.java:83) ~[?:?] at com.thevoxelbox.voxelsniper.sniper.Sniper.getCommandSender(Sniper.java:90) ~[?:?] at com.thevoxelbox.voxelsniper.cloud.bukkit.BukkitCommandManager.hasPermission(BukkitCommandManager.java:282) ~[?:?] at com.thevoxelbox.voxelsniper.cloud.CommandManager.hasPermission(CommandManager.java:427) ~[?:?] at com.thevoxelbox.voxelsniper.cloud.bukkit.BukkitCommand.testPermissionSilent(BukkitCommand.java:216) ~[?:?] at org.bukkit.craftbukkit.v1_20_R3.command.BukkitCommandWrapper.test(BukkitCommandWrapper.java:42) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at org.bukkit.craftbukkit.v1_20R3.command.BukkitCommandWrapper.test(BukkitCommandWrapper.java:1) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at com.mojang.brigadier.tree.CommandNode.canUse(CommandNode.java:79) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.commands.CommandDispatcher.a(CommandDispatcher.java:476) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.commands.CommandDispatcher.a(CommandDispatcher.java:449) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.server.players.PlayerList.a(PlayerList.java:1003) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.server.players.PlayerList.d(PlayerList.java:848) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.server.players.PlayerList.a(PlayerList.java:258) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.server.network.ServerConfigurationPacketListenerImpl.a(ServerConfigurationPacketListenerImpl.java:129) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.network.protocol.configuration.ServerboundFinishConfigurationPacket.a(SourceFile:20) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.network.protocol.configuration.ServerboundFinishConfigurationPacket.a(SourceFile:7) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.network.protocol.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:33) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.server.TickTask.run(SourceFile:18) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.util.thread.IAsyncTaskHandler.d(SourceFile:156) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.util.thread.IAsyncTaskHandlerReentrant.d(SourceFile:23) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1197) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:1) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.util.thread.IAsyncTaskHandler.x(SourceFile:130) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.server.MinecraftServer.bl(MinecraftServer.java:1176) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1169) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.util.thread.IAsyncTaskHandler.bu(SourceFile:115) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1152) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1060) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:304) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:3972-Spigot-ce0f71e-c00438b] at java.lang.Thread.run(Thread.java:1623) ~[?:?]

Here is a recent FAWE debugpaste: https://athion.net/ISPaster/paste/view/00497713259b49338b041f423ed0d85c

Aurelien30000 commented 8 months ago

Hey! Thanks for all your reports. I have finally found something unexpected under some circumstances that should be fixed in the following version: https://github.com/IntellectualSites/fastasyncvoxelsniper/actions/runs/7227688704?pr=335

Please test it thoroughly if you are able to! Anyways, keep in mind that this is a development version, not too risky though ;)