search

IntelliTect / CodingGuidelines

A repository to contain IntelliTect's tools for coding conventions
https://intellitect.github.io/CodingGuidelines/
MIT License
11 stars 17 forks source link

Exception guideline is obsolete #127

Closed Keboo closed 3 years ago

Keboo commented 4 years ago

The following exception guideline is obsolete:

:no_entry: AVOID: general catch blocks and replace them with a catch of System.Exception.

In addition to being obsolete the recommendation likely leads people into violating another rule:

:x: DO NOT: over-catch. Exceptions should be allowed to propagate up the call stack unless it is clearly understood how to programmatically address those errors lower in the stack.

Keboo commented 4 years ago

After discussion. This rule should be removed from the XML file.

⛔ AVOID: general catch blocks and replace them with a catch of System.Exception.

RenanOD commented 3 years ago

Thanks for the quick review! Issue can be closed after https://github.com/IntelliTect/CodingGuidelines/commit/bda86a2e9d9bd281947645d971e03885743551d9.