search

IntelliTect / TestTools

A collection of tools for aiding in test automation
MIT License
10 stars 7 forks source link

Fix up WebElement.cs #22

Closed PandaMagnus closed 5 years ago

PandaMagnus commented 6 years ago

Per Kevin in regards to one of the implemented properties that calls into ConditionalWait:

This should really be a method not a property. Properties are expected to be fast quick access to data, not long running async calls.

Same comment from the other properties.

Basically, we need to figure out if it's worth continuing to implement IWebElement for this or not.

PandaMagnus commented 6 years ago

Okay, with the way the conditional wait is now implemented, it's possible to make extensions that wrap the selenium functionality. This will allow us to nuke the WebElement class and move just a handful of methods into the WebElementExtensions class.

PandaMagnus commented 5 years ago

Nuked the webelement class in favor of IWebelement extension methods.