search

IntelliTect / TestTools

A collection of tools for aiding in test automation
MIT License
10 stars 7 forks source link

Selenate.InitWebDriver default IE Options cause some tests to fail #56

Closed philspokas closed 3 years ago

philspokas commented 5 years ago

Details are to be determined. But, the ideal solution is to provide over-ridable capabilities that can be driven by the tests.

PandaMagnus commented 5 years ago

@philspokas I definitely want to fix the default options, but there is a constructor overload to pass in your own driver with your own defined capabilities.

If there is a need for an... "in-between" solution, would it be acceptable to provide one of the following: 1) Implement a builder pattern for building and providing a Browser (this would be longer term, probably targeted to a v2 of Selenate.) Part of that would be specifying capabilities beyond/instead of the boilerplate ones we've provided. 2) An InitDriver or constructor overload that takes a params argument of key value pairs for the capabilities, and IF that's used, use those and only those when spinning up a driver.

Thoughts?

PandaMagnus commented 3 years ago

@philspokas Any issues with me closing this due to people moving to Edge? Or should I actually try to figure out what happened here for legacy clients?

It was not my intention to wait this long, but since we're here... And also if Playwright gets more adoption, it's possible Selenium might get knocked off of its perch.

philspokas commented 3 years ago

I'm good with closing