Using system.text.json instead of newtonsoft

IntelliTect / TestTools

A collection of tools for aiding in test automation

MIT License

10 stars 7 forks source link

Using system.text.json instead of newtonsoft #99

Closed qtuu closed 3 years ago

qtuu commented 3 years ago

This PR takes a stab at issue #62 As far as i can tell, the json conversion is only used for logging purposes. there will be some differences in the output and serialization behavior. See migration documentation for a detailed overview.

Example shortcomings of this solution:

Polymorphic serialization of properties does not work as it did with Newtonsoft.
There is no substitute for the TypeNameHandling option. We could write a custom serializer and add the TypeName as a separate Field.

Keboo commented 3 years ago

LGTM @PandaMagnus?

PandaMagnus commented 3 years ago

@qtuu Quick note: apparently I forgot to add the pipeline YMLs to the solution. We'll need to bump up the NuGet version for this.

qtuu commented 3 years ago

@qtuu Quick note: apparently I forgot to add the pipeline YMLs to the solution. We'll need to bump up the NuGet version for this.

Alright, I will have a look at that tomorrow evening. I am not sure how you guys handle the version bump, but I think I can figure it out. :)

qtuu commented 3 years ago

@PandaMagnus I increased the patch version and rebased changes from master into my fork.