search

Intellicode / eslint-plugin-react-native

React Native plugin for ESLint
MIT License
722 stars 130 forks source link

Switch rules to object export style (fixes eslint v8+) #299

Closed idolize closed 3 years ago

idolize commented 3 years ago

Fixes https://github.com/Intellicode/eslint-plugin-react-native/issues/298. Verified all tests pass.

From eslint docs:

In ESLint v7.0.0, rules that were written as a function (rather than object) were able to provide fixes. In ESLint v8.0.0, only rules written as an object are allowed to provide fixes and must have a meta.fixable property set to either "code" or "whitespace".

idolize commented 3 years ago

FYI @Intellicode

Intellicode commented 3 years ago

Hi @idolize, thanks for your PR! Could you maybe rebase such that the build can be picked up? It was broken due to the deprecation of the configured build image.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idolize commented 3 years ago

@Intellicode I just did a rebase squash - hopefully that triggers the new build appropriately!

manovotny commented 2 years ago

@Intellicode any idea when you'll cut a new release for this so we can get rid of the npm / yarn warning on not having || ^8?

npm WARN eslint-plugin-react-native@3.11.0 requires a peer of eslint@^3.17.0 || ^4 || ^5 || ^6 || ^7 but none is installed. You must install peer dependencies yourself.