search

IntelligentRoboticsLab / dnt-hulk

GNU General Public License v3.0
5 stars 0 forks source link

Implement dynamic team size (7v7 -> 5v5) #63

Closed oxkitsune closed 1 year ago

oxkitsune commented 1 year ago

We are playing 5v5, but we only support 7v7.

We should make team size dynamic, and not hardcoded

Fyor commented 1 year ago

Players are hardcoded AF!

pub struct Players<T> {
    pub one: T,
    pub two: T,
    pub three: T,
    pub four: T,
    pub five: T,
    pub six: T,
    pub seven: T,
}

The whole system is built on this principle. Changing this would be quite a whole lot of work. And I believe we don't have the time for this. So hardcoded it will be.

oxkitsune commented 1 year ago

What's stopping us from simply swapping this to a normal Vec<T> in most places?

Fyor commented 1 year ago

A lot of work that seems to be unnecessary as changing the number of players almost never happens. Hulks won't get anything out of it and it will be less Rusty as everything will be done with vectors instead of the more safe and better solution that is currently in use. It will be a large re-write as many generic T types use this system: InitialPose, Option, Penalty, Option, Option. And all that changed for nothing affected on the field.

Fyor commented 1 year ago

Also things like this wouldn't work anymore: SerializeHierarchy