search

IntelligentRoboticsLabs / gb_visual_detection_3d

89 stars 32 forks source link

last_detection_ts_ time out in update loop should be configurable #37

Open AravindaDP opened 4 years ago

AravindaDP commented 4 years ago

https://github.com/IntelligentRoboticsLabs/gb_visual_detection_3d/blob/melodic/darknet_ros_3d/src/darknet_ros_3d/Darknet3D.cpp#L168 It's better to use a rosparam threshold instead hardcoded value of 2 seconds.

I'm happy to make a PR if this is a welcome enhancement.

fgonzalezr1998 commented 4 years ago

Yes, it should be a parameter. Feel free to make a PR if you want @AravindaDP