search

IntelligentSoftwareSystems / Galois

Galois: C++ library for multi-core and multi-node parallelization
http://iss.ices.utexas.edu/?p=projects/galois
Other
310 stars 131 forks source link

make test doesn't attempt to verify correctness in lonestar/gpu/analytics programs #373

Open MrZmann opened 3 years ago

MrZmann commented 3 years ago

Make test seems to succeed for gpu programs no matter what the output is. For instance, I commented out the kernel calls for sssp and pagerank which are responsible for calculating the output and copying it back to the device (gg_main_pipe_1_wrapper). Make test will still succeed even though the output for every single line is exactly the same. It would be nice to at least add a check that the values have changed. This will give users a quick way of identifying if things are running on the GPU at all.

nicelhc13 commented 2 years ago

I am sorry for the late response. Thank you for your good suggestion. The one possible way that I could imagine now is to add a simple test with expected output. IMO, this should be not only gpu, but also cpu. I will raise this issue at the next release.