search

Inter-Actief / amelie

De website van Inter-/Actief/. Vernoemd naar de film Amélie.
https://www.inter-actief.utwente.nl/
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Upgrade to Bootstrap 4! (or 5) #214

Open Sophietje opened 7 years ago

Sophietje commented 7 years ago

Nick (@nickschot) has added Bootstrap to the website so that we can start using things such as table-responsive. At the moment we aren't using that much of bootstrap due to which it is likely preferable to switch to Bootstrap 4 now, as it will require less work than when more Bootstrap elements are used.

windwarrior commented 7 years ago

We do use a lot of bootstrap, the entire responsive layout is based on bootstrap... For now I would reccomend against BS4, because it is marked alpha by its developers. Maybe we should reconsider when BS4 becomes beta software :smile:.

nickschot commented 7 years ago

The latest alpha has been released, there won't be any major feature additions. The only stuff we use from bootstrap right now is the grid (which is mostly backwards compatible, just different breakpoints and more features) and the navbar (of which we only use the less right now...).

Having built multiple applications w/ basically all 6 alpha's of bootstrap 4, I'd recommend doing it asap as it spares us a more costly migration in the future. The only change necessary right now is porting the less we have to SCSS, which is very minor (replacing @ w/ $ is enough for variables and we don't use much (if any?) advanced functionality).

This also opens up the way for i.e. flexbox as supported by BS4.

windwarrior commented 7 years ago

Flexbox also implicitly means dropping support for IE <9, but I think thats fine :).

2017-03-07 16:26 GMT+01:00 Nick Schot notifications@github.com:

The latest alpha has been released, there won't be any major feature additions. The only stuff we use from bootstrap right now is the grid (which is mostly backwards compatible, just different breakpoints and more features) and the navbar (of which we only use the less right now...).

Having built multiple applications w/ basically all 6 alpha's of bootstrap 4, I'd recommend doing it asap as it spares us a more costly migration in the future. The only change necessary right now is porting the less we have to SCSS, which is very minor (replacing @ w/ $ is enough for variables and we don't use much (if any?) advanced functionality).

This also opens up the way for i.e. flexbox as supported by BS4.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Inter-Actief/amelie/issues/214#issuecomment-284753508, or mute the thread https://github.com/notifications/unsubscribe-auth/AAoTxSg4nQwkQOTsL6IoWDcgs8MzQIbpks5rjXcqgaJpZM4MVQeP .

Kurocon commented 7 years ago

I'd rather not use alpha software, so I'd like to wait for it to become beta at the very least. We could however start implementing it in a separate branch with the alpha, and switching to the beta once it's released.

pieter-bos commented 7 years ago

The site says beta now :D

AVeenstra commented 6 years ago

Wait till it is a month in production... there are too many differences between the alphas and betas.

windwarrior commented 6 years ago

Bootstrap 4 is also breaking, f.e. removes glyphicons…

https://getbootstrap.com/docs/4.0/migration/