Open marrold opened 4 months ago
Hi,
I noticed when requirefromhelomatch is set to no, evergreen navigation breaks. ? and q work, but the arrow keys do not.
# Pastebin pa1RfNUL 2024-05-08 21:38:39 evergreen.c:2356 [load_config] Processed option 'd' 2024-05-08 21:38:39 evergreen.c:2356 [load_config] Processed option 'd' 2024-05-08 21:38:39 evergreen.c:2356 [load_config] Processed option 'd' 2024-05-08 21:38:39 evergreen.c:2356 [load_config] Processed option 'd' 2024-05-08 21:38:39 evergreen.c:2356 [load_config] Processed option 'd' 2024-05-08 21:38:39 evergreen.c:2356 [load_config] Processed option 'l' 2024-05-08 21:38:39 evergreen.c:2143 [process_option] Processed option 'fromname' 2024-05-08 21:38:39 evergreen.c:2143 [process_option] Processed option 'fromaddr' 2024-05-08 21:38:39 evergreen.c:2143 [process_option] Processed option 'imap-username' 2024-05-08 21:38:39 evergreen.c:2143 [process_option] Processed option 'imap-password' 2024-05-08 21:38:39 evergreen.c:2143 [process_option] Processed option 'smtp-password' 2024-05-08 21:38:39 evergreen.c:308 [client_term_init] Terminal dimensions are 24 rows, 80 cols 2024-05-08 21:38:39 evergreen.c:2459 [main] --------------- Starting session --------------- 2024-05-08 21:38:39 imap.c:103 [client_connect] Connecting to 127.0.0.1:143 2024-05-08 21:38:39 imap.c:131 [client_login] Authenticating to IMAP server 2024-05-08 21:38:39 imap.c:481 [__client_list] Querying mailbox list 2024-05-08 21:38:39 imap.c:381 [list_status_logger] Queried status of INBOX 2024-05-08 21:38:39 imap.c:789 [client_select] Mailbox INBOX has changed since last select 2024-05-08 21:38:39 imap.c:649 [load_quota] Mailbox 'INBOX', usage 80, limit 9765 2024-05-08 21:38:39 imap.c:850 [client_select] Selected 'INBOX' 2024-05-08 21:38:39 imap.c:752 [find_specialuse_mailbox] Auto-determined Trash mailbox for INBOX: Trash 2024-05-08 21:38:39 imap.c:752 [find_specialuse_mailbox] Auto-determined Junk mailbox for INBOX: Junk 2024-05-08 21:38:39 imap.c:752 [find_specialuse_mailbox] Auto-determined Sent mailbox for INBOX: Sent 2024-05-08 21:38:39 imap.c:752 [find_specialuse_mailbox] Auto-determined Drafts mailbox for INBOX: Drafts 2024-05-08 21:38:39 evergreen.c:1258 [adjust_start_seqno] Adjusted current range from [0:0] -> [0,0] (total: 0) 2024-05-08 21:38:39 imap.c:1279 [client_fetchlist] Mailbox 'INBOX' is empty 2024-05-08 21:38:39 evergreen.c:320 [set_focus] Setting window focus to 1 2024-05-08 21:38:39 imap.c:2050 [client_idle_start] Starting IDLE... 2024-05-08 21:38:44 evergreen.c:2047 [client_menu] Ignoring unbound key 91 2024-05-08 21:38:44 evergreen.c:2047 [client_menu] Ignoring unbound key 68 2024-05-08 21:38:46 evergreen.c:2047 [client_menu] Ignoring unbound key 91 2024-05-08 21:38:46 evergreen.c:2047 [client_menu] Ignoring unbound key 68 2024-05-08 21:38:46 evergreen.c:2047 [client_menu] Ignoring unbound key 91 2024-05-08 21:38:46 evergreen.c:2047 [client_menu] Ignoring unbound key 66 2024-05-08 21:38:46 evergreen.c:2047 [client_menu] Ignoring unbound key 91
Sorry it's taken a while to look at this. I looked at the log and it looks like the message pane was active ("Setting window focus to 1"), and also that the mailbox was empty ("Mailbox 'INBOX' is empty"). As such, the up and down arrow keys would not have done anything because there are no messages to navigate. However, the left key should have shifted focus to the folder pane, and allowed you to navigate that. Is that not the case?
My guess is that this really had nothing to do with the requirefromhelomatch setting (I certainly don't see how it could), but a confirmation on this would be good.
I do think that maybe the lack of feedback from the UI could be confusing, so if nothing's happening, maybe we can add a message in the footer like "Mailbox is empty" if the arrow keys are used in the message pane on an empty mailbox? I forget if that's there already, but if not, I can add it. Let me know what you think.
Hi,
I noticed when requirefromhelomatch is set to no, evergreen navigation breaks. ? and q work, but the arrow keys do not.