Closed Sophist-UK closed 2 years ago
P.S. I should add that this is a new Laravel project. I installed Laravel and Modular and debugbar and created a couple of modules and went to test that the Laravel welcome page still displayed and got this error.
@Sophist-UK can you try the dev-main
release and confirm that your PR has resolved the Windows path issues?
I can test this as soon as my laptop is back running (awaiting new power brick).
I have just tested this and can confirm that it fixed the issue I was having above.
Fixed by #38
As you can see the
$path
contains a mixture of\
and/
. I believe that this then triggers an issue in theextractModuleNameFromPath
function inSupport/ModuleRegistry.php
.In essence developers of PHP code have a choice - they can either:
DIRECTORY_SEPARATOR
every time; or/
all the time (which generally are converted by PHP to\
on Windows) and just make sure to replace\
with/
whenever you get a real path given by the user or by PHP. A little internet research suggests that this is preferred / recommended because URLs use/
.It appears that in InterNachi Modular we have a mixed usage.