search

InterNations / http-mock

Mock HTTP requests on the server side in your PHP unit tests
http://www.internations.org
MIT License
391 stars 62 forks source link

Fixes #53 Do not interpret log output as errors #54

Closed mtils closed 4 years ago

mtils commented 4 years ago

In PHP 7.4 the built in PHP web server started to output every request on the console. The changes filter all non error lines before checking for errors. No failing tests under 7.4 now. Please check the tests from PHP 7.1 to 7.4 to be sure. But the fix should work in every version.

mtils commented 4 years ago

Oh sorry. Now I saw that phpcs was the reason for not building on travis. I will perform ./vendor/bin/phpcs --standard=vendor/internations/kodierungsregelwerksammlung/ruleset.xml ./src/ next time myself. Then you dont need to comment every style issue...

gabfr commented 4 years ago

I totally agree with all the small code changes but with this second look on my code realized I had to implement the method in Server. This will make it more clean. Do you agree? I can implement the changes in both ways. Just let me know.

Makes sense! As you said: The other classes should not be aware of "logs needs to be filtered".

mtils commented 4 years ago

Not needed anymore...