Closed maxheyer closed 2 years ago
Hi, since the DomainrobotService does not pass messages from thrown exceptions, it is not easy to debug any errors responded by the api.
The sdk should pass any exception message to the public api.
I am likely to create a pull request to fix the described issue.
I would suggest the to reuse the message from the previous exception instead of "Domainrobot Error" in src/Service/DomainrobotService.php:
Line 128
throw new DomainrobotException($contents, $exception->getResponse()->getStatusCode(), "Domainrobot Error");
TO
throw new DomainrobotException($contents, $exception->getResponse()->getStatusCode(), $exception->getMessage());
Line 133
throw new DomainrobotException($msg, $exception->getCode(), "Domainrobot Error");
throw new DomainrobotException($msg, $exception->getCode(), $exception->getMessage());
Hi, thanks for your input. We've added the requested changes to the SDK. Hopefully it's now easier to debug the API.
If you have further questions we're happy to help.
Hi, since the DomainrobotService does not pass messages from thrown exceptions, it is not easy to debug any errors responded by the api.
The sdk should pass any exception message to the public api.
I am likely to create a pull request to fix the described issue.
I would suggest the to reuse the message from the previous exception instead of "Domainrobot Error" in src/Service/DomainrobotService.php:
Line 128
TO
Line 133
TO