search

InterPSS-Project / ipss-plugin

InterPSS plugin projects
8 stars 11 forks source link

Consolidate BaseDStabDslRunner.run() and DStabDslRunner.runDstab() #15

Closed jinjingfarm closed 9 years ago

jinjingfarm commented 9 years ago

IDslRunner.run() is a generic method. The signature should be used for all DslRunner implementations. Therefore, DStabDslRunner.runDstab() could be refactored to use the IDslRunner.run() signature.

thuang commented 9 years ago

The functions of run and runDstab are not the same, runDstab is designed to help reuse the code: The run() includes the data input and result output, which we would like to reuse, as it is common for different types of DStab simulations. And runDstab() now is designed as a protected method, and for performing dynamic simulation only (not data input or result putput). You may regard it as a sub-routine of run() and the exact extension point for customized DStab simulation.

jinjingfarm commented 9 years ago

Ok, make runDstab() a protected method will avoid confusion, prevent someone to call runDstab() accidentally.