Open vcharpenay opened 1 year ago
Patch coverage: 61.62
% and project coverage change: -2.07
:warning:
Comparison is base (
e48a1d4
) 87.53% compared to head (ea17fda
) 85.46%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi @vcharpenay, I have this PR in mind to be looked this week (also see how to increase coverage to target).
Would you consider the branch stable enough to be merged with main?
We've used this version of the lib in the ai4industry summer school last week. I also used it in another project. The binding API has been quite stable since then, and we haven't found bugs in the HTTP binding so far. I haven't tried to integrate the CoAP binding, though. I don't have a test bed for that.
@vcharpenay is the README up to date?
The code base to merge has a generic API for protocol bindings. See the entry point
bindings.ProtocolBindings
. Clients can initiate operations without knowledge of the underlying protocol (HTTP, CoAP or anything else), as suggested in #72.HTTP and CoAP bindings have been updated accordingly. Other protocol bindings are available for OPC-UA and for ROS.
The README isn't up to date regarding e.g.
TdHttpRequest
. It should be updated before merging.