Closed achimschloss closed 4 years ago
Adding here - the language around default legal basis is already present in the spec, but just in the annotated example global vendor list - seem even more reasonable to give this a bit more visibility. What missing here is that the default can only be changes via a restriction.
`
@asr-enid thanks, the changes look good to me. What about also adding to the CMP guidelines that CMPs can avoid sending redundant information, as per the gdoc here? https://docs.google.com/document/d/1yoYN-iD7wlLjPt1DyEYN8KFAyiO_yZGk_CWhiWOnqAI/edit?disco=AAAAG15TmLU&ts=5f720228&usp_dm=false I can review if you take the lead and add it, so we can get this moving forward quickly. Thanks!
@Facens - you mean within the general implementation guidelines? https://github.com/InteractiveAdvertisingBureau/GDPR-Transparency-and-Consent-Framework/blob/master/TCFv2/TCF-Implementation-Guidelines.md#cmp
@asr-enid Yes! This is what we've agreed on the latest group meeting.
Ok - will add something to this pull request (makes sense given its the same context), would like to get this closed
Added some language in the implementation guidelines to reflect in which cases restrictions are necessary. Added some language that this does not preclude encoding schemes that might deviate (as suggested by @chrispaterson ) from this because they might be more space efficient with the same results
@Facens - let me know what you think - I'd find it highly valuable to have both clarifications merged soon.
@alextcone I'm good - accepted the changes from @Facens and changed the language on purpose restrictions as well as leaving vendor bits undefined rather them setting them to 0 (last commit) as suggested
@asr-enid & @Facens - I'm reviewing the latest now and hope to have this merged by tomorrow close of business on the East Coast of the US.
@asr-enid Take a look at my comments too, all minor tweaks in English, my bad for not creating a review and filing them as single comments, thought I could convert them but can't find a way. Lmk!
I think we are good now, also applied the editorial comments (all but one) in https://github.com/InteractiveAdvertisingBureau/GDPR-Transparency-and-Consent-Framework/pull/244/commits/30f1686167747549e624380110ecc1d4412ca91f - GH fortunately supports batching single review comments together
I think we're good! @alextcone FF to give it a final read and merge!
As discussed in https://github.com/InteractiveAdvertisingBureau/GDPR-Transparency-and-Consent-Framework/pull/220 - some more explicit description in the section "What are publisher restrictions?". Looking at the discussion it seem good to make it more explicit
@chrispaterson the TC Core String details description contains some language in the notes that restrictions should be respected even without flexibility, not sure I you'd want to change that given the code would not even allow them to be written just now