search

InteractiveAdvertisingBureau / SIMID

Secure Interactive Media Interface Definition (SIMID)
https://interactiveadvertisingbureau.github.io/SIMID/
Apache License 2.0
47 stars 25 forks source link

Browser support #146

Closed advir1 closed 5 years ago

advir1 commented 5 years ago

https://github.com/InteractiveAdvertisingBureau/SIVIC/blob/5af81aa12157e4d4377455e7ba73fda184c3de52/examples/sivic_protocol.js#L55

Browsers representing 5% of global use (IE 11, Opera Mini) do not support JS Promise Have we officially decided not to support those browsers in the SIVIC protocol?

https://caniuse.com/#feat=promises

andmig commented 5 years ago

Message protocol doesn't user `Promise' object. The code example, perhaps, has nothing to do with SIVIC protocol. The idea of promise in the message protocol is just a loosely borrowed concept that mimics promise flow. In fact, because messaging cannot provide callbacks - it cannot realize true Promise functionality. This is in addition to elevated possibilities of asynchronous messages reporting which, in turn, makes it impossible to create solid Promise concept utilization.

ryanthompson591 commented 5 years ago

Good point. I think this boils down to a few questions for the meeting:

  1. Is it ok for our sample code not to support older browsers?
  2. Does the current spec make it sound like promises are required? (should it?)
ryanthompson591 commented 5 years ago

Resolved. There should be a comment in the code: Promises don't work in IE 11 so we should add a comment that recommends a polyfil for browsers without promises.