search

InteractiveAdvertisingBureau / SIMID

Secure Interactive Media Interface Definition (SIMID)
https://interactiveadvertisingbureau.github.io/SIMID/
Apache License 2.0
47 stars 25 forks source link

Who is calling the Creative ready() function? #151

Closed advir1 closed 5 years ago

advir1 commented 5 years ago

https://github.com/InteractiveAdvertisingBureau/SIVIC/blob/5af81aa12157e4d4377455e7ba73fda184c3de52/examples/creatives/base_sivic_creative.js#L58

ryanthompson591 commented 5 years ago

Right now I'm calling it in: examples/creatives/sivic_overlay.html

I think the right thing to do is have some better way to illustrate that ready should be called only when all assets are loaded.

Will leave this open and do that in a separate PR.

ryanthompson591 commented 5 years ago

The decision was that creative.ready would no longer be an api. However, creative.ready (in the sample code) establishes the connection. We can create a PR if this looks confusing later on.