search

InteractiveAdvertisingBureau / SIMID

Secure Interactive Media Interface Definition (SIMID)
https://interactiveadvertisingbureau.github.io/SIMID/
Apache License 2.0
47 stars 25 forks source link

why explicitly not put SIVIC version in VAST? #213

Closed gasperk closed 4 years ago

gasperk commented 5 years ago

https://github.com/InteractiveAdvertisingBureau/SIVIC/blob/ddec151d43b41055e1146f8aa37fafd09a7e6ef4/index.bs#L1005-L1006

graphicdeveloper commented 5 years ago

I don't see any reason not to - but perhaps I missed whatever conversation let do this decision.

amitshetty commented 5 years ago

Do we need an update to the InteractiveCreative node? maybe add a "version" attribute? @pietermees @ryanthompson591 @aronschatz

amitshetty commented 5 years ago

Also, do we need a macro defined to describe the sivic + version number supported by the client? I guess it is the APIFRAMEWORKS macro?

aronschatz commented 5 years ago

The macro mentioned should work, unless I'm mistaken.

ryanthompson591 commented 5 years ago

We had a long argument about this at one point that ended in a stalemate.

I think the argument was what a player should do if it didn't support the given version. My feeling was that the ad should error out. Andre felt the player should try to render the ad anyhow.

I mean there's nothing wrong with putting a version number in there, the only problem is defining what the player must do with it.

amitshetty commented 5 years ago

Yes - seems like at a minimum it seems worth communicating the version number and leave out any direction on what the player should do.

Of course, in the ideal world it wont be a problem if the 4.1 ad requests are implemented so the VAST tag always only includes the version supported by the client.

amitshetty commented 5 years ago

Hmm - did we want to add this to VAST 4.2?

aronschatz commented 5 years ago

No, the list comes from AdCOM... I'll ping the OpenRTB group to get SIMID v1 added...

aronschatz commented 5 years ago

Whoops, didn't want to close

aronschatz commented 5 years ago

3rd reply! I misread this, we should discuss (again) on the next call.

amitshetty commented 4 years ago

Closing for now. Will revisit later if needed.