search

InteractiveAdvertisingBureau / SIMID

Secure Interactive Media Interface Definition (SIMID)
https://interactiveadvertisingbureau.github.io/SIMID/
Apache License 2.0
45 stars 24 forks source link

Error codes are confusing pr redundant. #401

Closed andmig closed 3 years ago

andmig commented 4 years ago

We should revisit error codes. Some of them seem to describe the same matters. For example, code1105 states: 1105 | Request for expand not honored. | The creative requested to expand but the player did not allow it.

Meanwhile, several codes in with 12XX numbers are introduced to describe nonlinear expansion use cases.

aronschatz commented 4 years ago

For 1105: The creative requested to expand the media playback window but the player did not allow it.

For the 12xx expands... I would either add "nonlinear" to them or say overlay which is consistent with AdCOM. I can make a PR for this after confirming.

aronschatz commented 4 years ago

Change media playback window to media player. Will submit a PR.

aronschatz commented 3 years ago

410