InteractiveAdvertisingBureau / SIMID

Secure Interactive Media Interface Definition (SIMID)
https://interactiveadvertisingbureau.github.io/SIMID/
Apache License 2.0
45 stars 24 forks source link

Swap SIMID:Creative:clickThru's url and SIMID:Player:init's clickThruUrl for uri equivalents #429

Closed nchavez324 closed 2 years ago

nchavez324 commented 2 years ago

This matches URI, which is used in SIMID:Creative:requestNavigation, and is more accurate with regards to the VAST spec:

From 4.2, Section 3.10.1:

The is a URI to the advertiser’s site that the media player opens when a viewer clicks the ad. The clickthrough is available in the InLine and Wrapper formats and is used when the Linear ad unit cannot handle a clickthrough.

The existing arguments are left intact to preserve backwards compatibility, but are deprecated in favor of the consistent forms.


:boom: Error: 400 Bad Request :boom:

PR Preview failed to build. (Last tried on Feb 24, 2022, 2:44 AM UTC).

More PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [CSS Spec Preprocessor](https://api.csswg.org/bikeshed/) - CSS Spec Preprocessor is the web service used to build Bikeshed specs. :link: [Related URL](https://api.csswg.org/bikeshed/?url=https%3A%2F%2Fraw.githubusercontent.com%2FInteractiveAdvertisingBureau%2FSIMID%2F04ee4888182237e3b087854a5e62abcc3d82d386%2Findex.bs&md-warning=not%20ready) ``` Error running preprocessor, returned code: 2. FATAL ERROR: Line 513 isn't indented enough (needs 1 indent) to be valid Markdown: " * New messages [[#simid-creative-expandNonlinear]], [[#simid-creative-collapseNonlinear]], and [[#simid-player-collapseNonlinear]] and related data." ✘ Did not generate, due to fatal errors ``` _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20InteractiveAdvertisingBureau/SIMID%23429.)._
nchavez324 commented 2 years ago

Yep, we talked about making this change this week.