search

InteractiveAdvertisingBureau / SIMID

Secure Interactive Media Interface Definition (SIMID)
https://interactiveadvertisingbureau.github.io/SIMID/
Apache License 2.0
45 stars 24 forks source link

Missing requestExitFullScreen message in CreativeMessage dictionary #437

Open jakraskin opened 1 year ago

jakraskin commented 1 year ago

Hi IAB,

We noticed that the CreativeMessage dictionary does not currently contain a constant for requestExitFullScreen. Can we please update the sample code to include something like REQUEST_EXIT_FULLSCREEN in CreativeMessages? Having the constant explicitly defined would prevent creatives and players from potentially using different constants for requestExitFullScreen (e.g., REQUEST_EXIT_FULLSCREEN or REQUEST_EXIT_FULL_SCREEN).

Thanks! Josh

aronschatz commented 1 year ago

The repo is open for pull requests, feel free to submit one to correct this.

jakraskin commented 1 year ago

Thank you - I went ahead and submitted PR #438