InteractiveAdvertisingBureau / iabtcf-es

Official compliant tool suite for implementing the Transparency and Consent Framework (TCF) v2.0. The essential toolkit for CMPs.
Apache License 2.0
129 stars 95 forks source link

Support for new official languages sr-cyrillic and sr-latin #199

Open mmuras opened 4 years ago

mmuras commented 4 years ago

Version Any

Module (core, cmpapi, cli, stub, or testing) Core

Describe with reproduction steps – What is the expected behavior? setting "sr-cyrillic" or "sr-latin" as parameter for gvl.changeLanguage() method throws Error

Because previous issue was closed without answer: https://github.com/InteractiveAdvertisingBureau/iabtcf-es/issues/183 I've created a new one with clarification that this languages are official ones: https://register.consensu.org/Translation. Also the mentioned problem with language code (rs instead of sr) was resolved by IAB Europe.

Please add this languages: https://vendorlist.consensu.org/v2/purposes-sr-cyrillic.json https://vendorlist.consensu.org/v2/purposes-sr-latin.json

to the list of known ones.

chrispaterson commented 4 years ago

I see, apologies. I was out of the loop on those translations.

chrispaterson commented 4 years ago

Looking this over I now realize the GVL only supports a 2-character ISO 639-1 language code. We'll likely need to support a IETF Language Tag, which accounts for regional and dialectic differences. The Language Tags for those would be sr-Cyrl and sr-Latn. I'm asking IAB Europe if they can change the filenames to follow a standardize convention. Also, asking if it's ok that both of these languages will be encoded into the SR into the TC string, despite them being different.

HeinzBaumann commented 4 years ago

Actually there are 3 letter language codes that encodes dialects. I think it is an ISO standard. That might be better to use, if we have to extend from 2 to something else.

zorkor commented 1 year ago

Hi, can we solve this somehow, any sugestions?

HeinzBaumann commented 1 year ago

Let me add this to the backlog for upcoming GVL changes.

marco-prontera commented 1 year ago

Hi, this thing will be fixed with #404, the solution I proposed doesn't require any changes from IAB GVL generator