InteractiveAdvertisingBureau / openvv

Other
81 stars 50 forks source link

Parsing browser agent to determine mozPaint/Beacons/Geometry... #105

Open seanmerrigan opened 9 years ago

seanmerrigan commented 9 years ago

In a debug branch, we switched the conditional used to determine if the MozPaintCount or Flash Beacon method should be used from: if ($ovv.browser.ID === $ovv.browserIDEnum.Firefox){ ... to: if ( !!window.mozPaintCount ) { ... and we've noticed that there are now a number of cases where the browserData.getBrowser() method claims the browser is a Firefox version that's capable of supporting MozPaintCount but the Flash beacon method is used instead. This indicates that (in the master version) the user agent parser is incorrectly identifying browsers that can't use mozPaintCount as Firefox.

Whenever possible we should check for supported properties instead of inferring them from the detected browser.