InteractiveAdvertisingBureau / openvv

Other
81 stars 50 forks source link

Chrome v48 - Beacons No Longer Throttle Causing False Positives on Viewability #114

Open advir1 opened 8 years ago

advir1 commented 8 years ago

Description: Chrome v48.0.2564.97 no longer throttles beacon frame rate when out of view or out of focus, causing false positives in viewability measurement

Steps to reproduce:

  1. Update Chrome to v48.0.2564.97
  2. Run an OVV-integrated ad in x-domain iframe
  3. Scroll down so that less than 50% of the player is visible

Expected result: Ad should be counted as not visible and OVVImpression event should not be dispatched

Actual result: Ad is counted as viewable and OVVImpression event is dispatched

idoradai85 commented 8 years ago

I think I found the issue. some of the beacons were working fine and some was not. when I compared I saw: the ones that worked had top/left position number with about 0-2 digits after the point (like 2.3 or 2352.0) the ones that didn't work had top/left position number with about 10 digits after the point (like 2.234253323 or 323.346343434) I used round on top/left and all the beacons seem to be working Pull request : https://github.com/InteractiveAdvertisingBureau/openvv/pull/115