search

InteractiveAdvertisingBureau / openvv

Other
81 stars 50 forks source link

Uncaught TypeError: Cannot read property 'right' of undefined #122

Open srgroves opened 8 years ago

srgroves commented 8 years ago

I noticed that in positionBeacons(), line 1399, it's accessing playerLocation.right without checking if playerLocation has been defined. It may not be, depending on what player.getClientRects returns. This causes the error in the title of this post. The last line below is 1399:

var playerLocation = player.getClientRects()[0];

// when we don't have an initial position, or the position hasn't changed 
if (lastPlayerLocation && playerLocation && (lastPlayerLocation.left === playerLocation.left && lastPlayerLocation.right === playerLocation.right && lastPlayerLocation.top === playerLocation.top && lastPlayerLocation.bottom === playerLocation.bottom)) {
    // no need to update positions
    return;
}

// save for next time
lastPlayerLocation = playerLocation;

var playerWidth = playerLocation.right - playerLocation.left;