Choose preset, Show top 10 suspicious items: more then 10 item appeared

[brita-sed]

Precondition

• .../eclipse.exe has launched.
• iFL plugin has been installed.

Steps

1. Select a project.
2. Click iFL button.
3. Load scores.
4. Select an item.
5. Right click > Context based feedback.
6. Set context to high values, to 1.000
7. Click OK button.
8. Click Show filters button.
9. Choose preset button.
10. Select Show top 10 suspicious items.
11. Click Apply preset.

Expected results

• Only the top 10 items will be displayed.

Received results

• More than 10 items appeared.

Environment:

• Package: https://github.com/sed-szeged/iFL4Eclipse/releases/tag/V2.duallist-sorting.3
• Operating System: Windows 10 Pro, 64 bit
• Eclipse version: 2019-09 R (4.13.0)

[brita-sed]

Reproduction steps are not clear, it should be investigated. Maybe there should be a sorting by Score set before choose a preset.

[geryxyz]

This could be a relic of a legacy feature since the card ui we never ever see more than 10 methods or entries. Should be discussed.

[Dhorvath1294]

It happened because the "Show top 10 items" feature works as a simple score filter. It orders the code elements by score (descending), and applies the score of the 10th element from the list as a score filter with a relation of "greater than or equal". Let's say we have 15 code elements with a score of "1.0". Now, if we apply the "Show top 10 items" preset, what happens is that these code elements get ordered by their scores (descending), and the score of the 10th element in that list gets applied as a score filter. Now all 15 elements are shown despite having used the "Show top 10 items" preset. Maybe the feature should be redefined as "Show items whose scores are in the top 10 highest scores in the project".

[brita-sed]

The feature name could be (if we would like to use a shorter one) "Show top 10 score items" or "Show top 10 scored items".