search

InteractiveMechanics / historyofvaccines-drupal8

0 stars 0 forks source link

[2] Timeline: Filters / Overview Text #193

Closed mtedeschi closed 8 years ago

mtedeschi commented 8 years ago

@jmaj and I already talked about this a bit, but adding it here. When you go to the timeline and use the "FILTERS" menu to select a category, it goes here:

http://lb88-ttgt.accessdomain.com/drupal/timeline?timeline_categories=All&timeline_categories=51

It then pulls up all items, not just items in category 51. If you then check "Polio" too, you get: http://lb88-ttgt.accessdomain.com/drupal/timeline?timeline_categories=51&timeline_categories=52

And only category 51 is selected at that point.

amberreeves commented 8 years ago

Additional comment from Karie:

When I select a filter, I'm seeing the All Timelines Overview text at the bottom.

After I've selected the yellow fever filter, then selected the measles filter and deselected yellow fever, the measles entries appear but the yellow fever box is checked in the filter (not the measles box).

jmaj commented 8 years ago

Filters have been updated to work properly, @mtedeschi and @amberreeves so what are we doing? I'm fine with selecting one filter if Karie wants the text at the bottom to update.

amberreeves commented 8 years ago

When I select 1 filter, the text below is that filter's text. When I select more than 1 filter, the text below is the All Timelines Overview text.

amberreeves commented 8 years ago

If a user chooses option 3 then option 1, the text below will be option 3's text

amberreeves commented 8 years ago

@jmaj Karie prefers that the All Timelines Overview text shows when more than 1 filter is selected

jmaj commented 8 years ago

There's an image issue and some pdf links aren't working

amberreeves commented 8 years ago

OK, I see that the filters and corresponding text below are working.

I see that the images associated with the text are broken. Is this something that you're able to fix today?

What is causing the pdf links to break? Is it something you can fix or is it something Karie will need to do?

mtedeschi commented 8 years ago

Update images with: http://media.historyofvaccines.org/images/

mtedeschi commented 8 years ago

For PDFs, just remove "inline-pdf" directory, so... http://www.historyofvaccines.org/sites/default/files/inline-pdfs/DIPHTHERIA_BIBLIOGRAPHY.pdf

Becomes... http://www.historyofvaccines.org/sites/default/files/DIPHTHERIA_BIBLIOGRAPHY.pdf

amberreeves commented 8 years ago

pdfs are there/linking/good to go.

images that could be recovered are there.

the first sentence in the text just needs to be properly aligned.

amberreeves commented 8 years ago

Looks good!