search

InteractiveMechanics / historyofvaccines-drupal8

0 stars 0 forks source link

[2-4] Timeline: Image switcher issues #248

Closed amberreeves closed 7 years ago

amberreeves commented 7 years ago

1) In this entry, the caption and source aren't changing when I click through the thumbnail images.

http://staging.historyofvaccines.org/timeline#EVT_102227

2) In this entry, the caption info changes when I click the video thumbnail, though the larger image doesn't change.

http://staging.historyofvaccines.org/timeline#EVT_100726

jmaj commented 7 years ago

The caption fixing has been updated, looking into the video not changing now.

jmaj commented 7 years ago

Updated the JS logic

mtedeschi commented 7 years ago

The switcher looks great, but I noticed a different JS issue on this entry: http://staging.historyofvaccines.org/timeline#EVT_102227

If you zoom in on the first one, it works. If you zoom in on the other four, they don't work (blank zoomer screen and no title). Looks like there is a JS error:

Uncaught TypeError: Cannot read property 'replace' of undefined at fixTitle (main.js?v=1.x:210) at populateMediaInfo (main.js?v=1.x:213) at HTMLDivElement. (main.js?v=1.x:168) at HTMLDocument.dispatch (jquery.min.js?v=2.2.3:3) at HTMLDocument.r.handle (jquery.min.js?v=2.2.3:3)

amberreeves commented 7 years ago

@jmaj let me know when this has been resolved