search

InteractiveMechanics / nmai-nk360-interactives

0 stars 0 forks source link

[x] Lightbox images should be larger versions #444

Closed amberreeves closed 6 years ago

amberreeves commented 6 years ago

when i click on a source image and the lightbox pops up, the image in the light box is the same size as the source image. it should be the larger one.

jmaj commented 6 years ago

I'm not resizing the images, they are just small?

Here's one that was in m1a1.json, here's an example image http://dev.interactivemechanics.com/nk360/3-resource-annotator/assets/imgs/m1a1/med-source-2.jpg

--

If you're going to edit the JSON, just let me know first, because I don't want commit issues.

mtedeschi commented 6 years ago

Just to confirm, the image displayed in the annotation area is the thumb, and the one in the lightbox is the full size image? I'd like to just confirm that the image we're using is the right size. @tespenshade can you look at this?

tespenshade commented 6 years ago

"thumbnail-" images are for the small cards that users see when they first open the app.

"med-" (for "medium size") images are meant to be shown in the annotation view. It's the image users drop markers on.

"full-" or full sized versions of the images should be pulled in and used for lightbox view when the user clicks on a zoom icon.

I see all the image sizes in the staging>imgs folders and on the drive.

@jmaj your link in the comment above leads to a "med-" image. "med-" images should not be used for lightbox.

Does that clarify things?

mtedeschi commented 6 years ago

I've changed all JSON files to pull the full- size image in for "image_url" instead of med-.