InteractiveMechanics / nmai-nk360-interactives

0 stars 0 forks source link

[x] ipad-portrait: Forced encounter locations are off #556

Closed tespenshade closed 6 years ago

tespenshade commented 6 years ago

Not sure if this means we need a different set of locations for when you play the game in portrait mode?

mtedeschi commented 6 years ago

We should not need multiple locations, we should adjust accordingly.

jmaj commented 6 years ago

So the iPad in potrait has some encounters off by 100 or so pixels and adjusting the numbers will make them off in landscape mode.

I'm not sure what's the best solution here. @mtedeschi and @tespenshade any idea on this issue?

mtedeschi commented 6 years ago

Is it consistently 100 pixels off? e.g. every location is 100 pixels off on portrait? If so, can we just check screen size and correct by that value?

jmaj commented 6 years ago

I can't say for sure if it's off that much, that's just what I noticed with the first two.

But it won't be a constant 100 pixel once we add the parallax animation.

mtedeschi commented 6 years ago

@jmaj and I talked about splitting the difference in the positions so that they appear right on all screens (e.g. if 1000 pixels is what is perfect except on mobile portrait which displays more like at 900 pixels, let's just make it 950 instead).

mtedeschi commented 6 years ago

This should be resolved by #301.